Repository navigation
Conversation
|
In case someone wants to experiment with it while I am away... |
|
Error while checking build/O2/fullCI_slc9 for e139bea at 2026-11-10 03:51: Full log here. |
|
ok, I should have said, in general I am fine with this change (as discussed in person). I also appreciate if people improve the documentation :). So please go ahead like this :). |
|
I am not sure if "people" is the right collective noun, but ok... ;-) |
3e4ca31 to
19719ae
Compare
The stage run with ENABLE_GPU_TEST=1 was hardcoded to CUDA. FST_GPUTYPE selects it, e.g. FST_GPUTYPE=METAL on macOS; the default stays CUDA.
|
@davidrohr I dropped all the things in the documentation you had comments on from the PR and I will open a separate one with just those. This one works for me to enable the metal backend. All that is left is the optimisations which I left for after your tracking changes. |
davidrohr
left a comment
There was a problem hiding this comment.
Looks good, except for I'd try to get rid of the cast for printf
| } | ||
| if (nEventsProcessed > 1) { | ||
| printf("Total: %ld clusters, %ld tracks\n", nClustersTotal, nTracksTotal); | ||
| printf("Total: %lld clusters, %lld tracks\n", (long long)nClustersTotal, (long long)nTracksTotal); |
There was a problem hiding this comment.
Can we get rid of the cast? Perhaps we can use size_t and %z?
There was a problem hiding this comment.
Should be done. I also changed nBunch to int32 for the other cast.
…pports it ENABLE_METAL defaults to AUTO like the other backends: it is used when the Metal toolchain compiles MSL 4.1 (macOS 27) and silently skipped otherwise. Notice that in any case by default we use the CPU, even when Metal is available.
ENABLE_METAL defaults to AUTO like the other backends: it is used when the
Metal toolchain compiles MSL 4.1 (macOS 27) and silently skipped otherwise.
Notice that in any case by default we use the CPU, even when Metal is available.