From 77b3f3d9d86bd37e457365e220fccd9eeadae0d5 Mon Sep 17 00:00:00 2001 From: tanjiro Kamado Date: Mon, 16 Nov 2026 11:48:01 +0530 Subject: [PATCH] fix: report NEXT VALUE FOR and s.NEXTVAL as possible data changes --- .../statement/StatementFeatureVisitor.java | 18 +++++++++++++++ .../StatementFeatureVisitorTest.java | 22 +++++++++++++++++++ 2 files changed, 40 insertions(+) diff --git a/src/main/java/net/sf/jsqlparser/statement/StatementFeatureVisitor.java b/src/main/java/net/sf/jsqlparser/statement/StatementFeatureVisitor.java index 46a096b1a..e7dfb0865 100644 --- a/src/main/java/net/sf/jsqlparser/statement/StatementFeatureVisitor.java +++ b/src/main/java/net/sf/jsqlparser/statement/StatementFeatureVisitor.java @@ -22,8 +22,10 @@ import net.sf.jsqlparser.expression.ExpressionVisitor; import net.sf.jsqlparser.expression.ExpressionVisitorAdapter; import net.sf.jsqlparser.expression.Function; +import net.sf.jsqlparser.expression.NextValExpression; import net.sf.jsqlparser.expression.TranscodingFunction; import net.sf.jsqlparser.parser.CCJSqlParserUtil; +import net.sf.jsqlparser.schema.Column; import net.sf.jsqlparser.statement.alter.Alter; import net.sf.jsqlparser.statement.alter.AlterExpression; import net.sf.jsqlparser.statement.alter.AlterOperation; @@ -1359,6 +1361,22 @@ public Void visit(TranscodingFunction expression, S context) { analyseFunction(expression.getKeyword()); return super.visit(expression, context); } + + /** NEXT VALUE FOR s advances the sequence, like nextval('s'). */ + @Override + public Void visit(NextValExpression nextVal, S context) { + analyseFunction("nextval"); + return super.visit(nextVal, context); + } + + /** So does Oracle's s.NEXTVAL, which the grammar keeps as a column. */ + @Override + public Void visit(Column column, S context) { + if (column.getTable() != null && "nextval".equalsIgnoreCase(column.getColumnName())) { + analyseFunction("nextval"); + } + return super.visit(column, context); + } } @Override diff --git a/src/test/java/net/sf/jsqlparser/statement/StatementFeatureVisitorTest.java b/src/test/java/net/sf/jsqlparser/statement/StatementFeatureVisitorTest.java index 0a16970ea..fe4ce53c4 100644 --- a/src/test/java/net/sf/jsqlparser/statement/StatementFeatureVisitorTest.java +++ b/src/test/java/net/sf/jsqlparser/statement/StatementFeatureVisitorTest.java @@ -743,6 +743,28 @@ void nestedWriteIsSeen(String sql) throws JSQLParserException { assertThat(f.returnsResultSet()).isTrue(); } + @ParameterizedTest(name = "{0}") + @ValueSource(strings = { + "SELECT NEXT VALUE FOR s", + "SELECT NEXTVAL FOR s", + "SELECT NEXT VALUE FOR dbo.s FROM t", + "SELECT a FROM t WHERE a = NEXT VALUE FOR s", + "SELECT s.NEXTVAL FROM dual", + "SELECT a FROM t WHERE a = (SELECT s.nextval FROM dual)"}) + void sequenceAdvanceIsChecked(String sql) throws JSQLParserException { + StatementFeatures f = analyse(sql); + assertThat(f.returnsResultSet()).isTrue(); + assertThat(f.mayModifyData()).isTrue(); + assertThat(f.getUnresolvedReferences()).containsExactly("nextval"); + } + + @Test + void columnOutsideTheSequenceSyntaxIsNotChecked() throws JSQLParserException { + StatementFeatures f = analyse("SELECT nextval, t.currval FROM t"); + assertThat(f.mayModifyData()).isFalse(); + assertThat(f.getUnresolvedReferences()).isEmpty(); + } + @Test void topLevelValuesReturnsRowsWithoutReading() throws JSQLParserException { StatementFeatures f = analyse("VALUES (1, 2)");