Repository navigation
Conversation
johnpryan
requested review from
a team,
bkonyi and
kenzieschmoll
as code owners
November 16, 2026 19:19
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances the DevTools extension server by enforcing security constraints on package roots and options files, ensuring they reside within active IDE workspace roots. It introduces validation logic in ExtensionsManager and file_system.dart to verify file URIs and resolve paths, along with comprehensive unit tests to cover these security checks. I have identified a syntax error in the workspace root resolution logic that requires a fix using Dart's pattern matching.
…oots Use shared helpers for verifying extension paths use isLocalFileUrl to check for file:// prefixes
johnpryan
force-pushed
the
confine-extension-package-root-uri
branch
from
November 17, 2026 16:41
ec9e5a0 to
d7f93c7
Compare
Contributor
Author
|
Discussed offline with @kenzieschmoll , there's a better approach here where we could avoid sending |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes sure that
packageRootUrican't probe arbitrary directories on the filesystem by providing afile://path outside of the user's project to theserveAvailableExtensionsendpoint.This makes the extension handler connect to DTD to check that:
.and..segments.This is the final change needed to close these issues:
Fixes https://github.com/flutter/dash-devexp-internal/issues/89
Fixes https://github.com/flutter/dash-devexp-internal/issues/91