Repository navigation
Conversation
… to be restarted anyway
There was a problem hiding this comment.
This PR works way better than I expected it to. I also only found one or two things I would consider a bug, the rest are only minor inconsistencies and code style issues.
- This PR drops support for mod name coloring:
- Trying to add an entity via left clicking the map opens the browsers context menu.
- Closing the browser window does not ask the user if they wish to save their changes.
- NIT: Most of the
changeDetection: ChangeDetectionStrategy.Eagercan be removed
| <mat-tree #tree [dataSource]="nodes" [childrenAccessor]="childrenAccessor" class="mapTree"> | ||
| <mat-tree-node *matTreeNodeDef="let node; when: isSection" class="mapTree-section" isExpandable> | ||
| <button class="section-header" matTreeNodeToggle> | ||
| <span class="section-name">{{ node.names[0] }}</span> |
There was a problem hiding this comment.
NIT: I would prefer to have an indication that this element is interactable, such as the expand_more and chevron_right icons.
Added it back
I can't reproduce it
There is a warning that unsaved changes will be lost
I'd like to do that together with moving to zoneless. There are still lots of components that need it. |
Sorry, I meant right clicking. Steps to reproduce:
It does not show for me. Steps to reproduce:
|
|
What browser are you using? I don't have these issues with chrome on ubuntu |
|
Chrome 157.0.8103.79 on Windows 11 |


Editor now uses file system access api to save/load files.