Skip to content

use file system access api - #363

Open
Vegita2 wants to merge 65 commits into
masterfrom
file-system-api
Open

Vegita2 wants to merge 65 commits into
masterfrom
file-system-api

Conversation

@Vegita2

@Vegita2 Vegita2 commented Nov 1, 2026 •

Copy link
Copy Markdown
Member

Editor now uses file system access api to save/load files.

  • editor now runs fully as a website. No need for backend. (Chromium Browsers only)
  • files are now saved from where they were loaded.
  • tons of simplifications, no need for separate backend/common projects anymore or electron specific code in the webapp
  • added support for base game DLC's
  • allow selecting multiple mods
  • added missing destructible types
  • updated to angular 22

@Vegita2
Vegita2 marked this pull request as ready for review November 14, 2026 23:33
@Vegita2
Vegita2 requested a review from 2767mr November 14, 2026 23:39

@2767mr 2767mr left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR works way better than I expected it to. I also only found one or two things I would consider a bug, the rest are only minor inconsistencies and code style issues.

  • This PR drops support for mod name coloring:
image
  • Trying to add an entity via left clicking the map opens the browsers context menu.
  • Closing the browser window does not ask the user if they wish to save their changes.
  • NIT: Most of the changeDetection: ChangeDetectionStrategy.Eager can be removed

<mat-tree #tree [dataSource]="nodes" [childrenAccessor]="childrenAccessor" class="mapTree">
<mat-tree-node *matTreeNodeDef="let node; when: isSection" class="mapTree-section" isExpandable>
<button class="section-header" matTreeNodeToggle>
<span class="section-name">{{ node.names[0] }}</span>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: I would prefer to have an indication that this element is interactable, such as the expand_more and chevron_right icons.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it but didn't really like it. I think the hover effect + cursor: pointer is enough. What do you think?

image

Comment thread webapp/src/app/tests/test-helper.ts Resolved
@Vegita2

Vegita2 commented Nov 18, 2026

Copy link
Copy Markdown
Member Author

This PR drops support for mod name coloring:

Added it back

Trying to add an entity via left clicking the map opens the browsers context menu.

I can't reproduce it

Closing the browser window does not ask the user if they wish to save their changes.

There is a warning that unsaved changes will be lost

NIT: Most of the changeDetection: ChangeDetectionStrategy.Eager can be removed

I'd like to do that together with moving to zoneless. There are still lots of components that need it.

@2767mr

2767mr commented Nov 18, 2026

Copy link
Copy Markdown
Member

Trying to add an entity via left clicking the map opens the browsers context menu.

I can't reproduce it

Sorry, I meant right clicking. Steps to reproduce:

image

There is a warning that unsaved changes will be lost

It does not show for me. Steps to reproduce:

@Vegita2

Vegita2 commented Nov 18, 2026

Copy link
Copy Markdown
Member Author

What browser are you using? I don't have these issues with chrome on ubuntu

@2767mr

2767mr commented Nov 18, 2026

Copy link
Copy Markdown
Member

Chrome 157.0.8103.79 on Windows 11

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants