Skip to content

feat(samply): bump the sampler to expand inlined JIT functions - #627

Draft
not-matthias wants to merge 1 commit into
mainfrom
cod-4271-multi-threaded-java-walltime-flamegraphs-lose-their
Draft

not-matthias wants to merge 1 commit into
mainfrom
cod-4271-multi-threaded-java-walltime-flamegraphs-lose-their

Conversation

@not-matthias

@not-matthias not-matthias commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

TLDR: Bumps the pinned sampler so functions inlined by a JIT show up as frames in walltime flamegraphs (no visible change until the JVM agent emits inlined-range entries).

Review notes

Closes COD-4284

The pinned sampler attributes every function a JIT compiler inlined to
the function it was inlined into, which hides most of the call tree of
Java benchmarks in walltime flamegraphs.

The new revision turns symbol map entries named
`<function>-><inlined>->...` into inline frames. It has no effect until
the JVM agent writes such entries.
@codspeed

codspeed Bot commented Nov 16, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

2 warnings

⚠️ Walltime results may be unreliable

Some benchmarks used the Walltime instrument outside CodSpeed Macro Runners, which can make the results inconsistent.

Learn more about Macro Runners

See affected benchmarks

⚠️ 8 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

✅ 53 untouched benchmarks
⏩ 6 skipped benchmarks1


Comparing cod-4271-multi-threaded-java-walltime-flamegraphs-lose-their (934b657) with main (ffdafa6)

Open in CodSpeed

Footnotes

  1. 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant