Skip to content

fix(valgrind): make the unsupported system error actionable - #628

Open
claude[bot] wants to merge 2 commits into
mainfrom
fix/actionable-unsupported-system-error
Open

claude[bot] wants to merge 2 commits into
mainfrom
fix/actionable-unsupported-system-error

Conversation

@claude

@claude claude Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Requested via Slack thread

Before:

Unsupported system

After:

Unsupported system: ubuntu 20.04 (x86_64).

Make sure you are running the latest version of CodSpeed first:
- On GitHub Actions, update `CodSpeedHQ/action` to its latest release.
- Elsewhere, run `codspeed update`.

The supported systems are listed in the documentation: https://codspeed.io/docs/cli#installation

If the error persists, reach out on Discord (https://codspeed.io/discord) or by email ([email protected]).

Makes the "Unsupported system" error name the detected system, tells users to update CodSpeed before contacting support, and points to the documentation for the supported systems instead of hard-coding them.

How: the advice lives in one UNSUPPORTED_SYSTEM_ADVICE constant in src/executor/valgrind/setup.rs. It is used by unsupported_system_error (both bail sites in get_codspeed_valgrind_target) and by the manual installation error returned by try_install_from_source. Linux hosts without a published package take that second path (support_level returns RequiresManualInstallation), so it is the error those users actually receive. The update command is the existing codspeed update (see src/cli/update.rs), the Discord link comes from the README, the support email from plugin.json, and the docs page is the one src/cli/update.rs already links to. Unit tests check both messages.


Generated by Claude Code

The "Unsupported system" error gave no detail, leaving users on an
outdated CodSpeed (e.g. an old action version on a new `ubuntu-latest`)
with nothing to act on.

Name the detected system and the supported ones, point to updating
CodSpeed first, and say where to get help if the error persists.

Co-Authored-By: François Farge <[email protected]>
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
@claude
claude Bot marked this pull request as ready for review November 16, 2026 13:11
@codspeed

codspeed Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

2 warnings

⚠️ Walltime results may be unreliable

Some benchmarks used the Walltime instrument outside CodSpeed Macro Runners, which can make the results inconsistent.

Learn more about Macro Runners

See affected benchmarks

⚠️ 8 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

✅ 53 untouched benchmarks
⏩ 6 skipped benchmarks1


Comparing fix/actionable-unsupported-system-error (c68337b) with main (ffdafa6)

Open in CodSpeed

Footnotes

  1. 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@greptile-apps

greptile-apps Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 4/5

[Low impact] The change affects the Valgrind setup message for unsupported systems.

The PR appears safe to merge, but the new advice will not reach users on unsupported hosts.

Fix All in Claude CodeFindings

  1. P2 Users never see the advice ▶
Fix with agent prompt
### Issue 1
src/executor/valgrind/setup.rs:17-20
On Ubuntu 20.04, `support_level` calls `get_codspeed_valgrind_target` through `.is_ok()`, discards this error, and sends the user to `try_install_from_source`. That path returns its own manual-install error without the new advice. The package-install path only runs for supported hosts, so it cannot surface this message either.

Add the update and support advice to the error users actually receive, and test that setup path.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

Adds a shared error message with the detected system, supported platforms, update commands, and support contacts.

  • Unsupported Valgrind systems now get their details and next steps in the error.

Reviews (1) · Last reviewed commit: "fix(valgrind): make the unsupported syst..." · Reviewed by Greptile

Comment thread src/executor/valgrind/setup.rs Resolved
Comment thread src/executor/valgrind/setup.rs Resolved
Do not bake the supported systems or CodSpeed versions in the unsupported
system error: link to the documentation, which lists them for the latest
version, and keep `codspeed update` as the only way to update the CLI.

Hosts without a published package go through the manual installation path
rather than the unsupported system error, so users never saw the advice.
Append it to the manual installation error as well.

Co-Authored-By: François Farge <[email protected]>
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
@claude
claude Bot requested a review from fargito November 16, 2026 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants