Repository navigation
fix(valgrind): make the unsupported system error actionable - #628
claude[bot] wants to merge 2 commits into
Conversation
The "Unsupported system" error gave no detail, leaving users on an outdated CodSpeed (e.g. an old action version on a new `ubuntu-latest`) with nothing to act on. Name the detected system and the supported ones, point to updating CodSpeed first, and say where to get help if the error persists. Co-Authored-By: François Farge <[email protected]> Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Merging this PR will not alter performance2 warnings
Comparing Footnotes
|
[Low impact] The change affects the Valgrind setup message for unsupported systems. The PR appears safe to merge, but the new advice will not reach users on unsupported hosts.
|
Do not bake the supported systems or CodSpeed versions in the unsupported system error: link to the documentation, which lists them for the latest version, and keep `codspeed update` as the only way to update the CLI. Hosts without a published package go through the manual installation path rather than the unsupported system error, so users never saw the advice. Append it to the manual installation error as well. Co-Authored-By: François Farge <[email protected]> Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Requested via Slack thread
Before:
After:
Makes the "Unsupported system" error name the detected system, tells users to update CodSpeed before contacting support, and points to the documentation for the supported systems instead of hard-coding them.
How: the advice lives in one
UNSUPPORTED_SYSTEM_ADVICEconstant insrc/executor/valgrind/setup.rs. It is used byunsupported_system_error(both bail sites inget_codspeed_valgrind_target) and by the manual installation error returned bytry_install_from_source. Linux hosts without a published package take that second path (support_levelreturnsRequiresManualInstallation), so it is the error those users actually receive. The update command is the existingcodspeed update(seesrc/cli/update.rs), the Discord link comes from the README, the support email fromplugin.json, and the docs page is the onesrc/cli/update.rsalready links to. Unit tests check both messages.Generated by Claude Code