Skip to content

chore: add zizmor (pre-commit) and fix its auditor findings - #6

Open
fstagni wants to merge 2 commits into
DIRACGrid:mainfrom
fstagni:zizmor-auditor
Open

fstagni wants to merge 2 commits into
DIRACGrid:mainfrom
fstagni:zizmor-auditor

Conversation

@fstagni

@fstagni fstagni commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Part of #5 (add zizmor everywhere as pre-commit), same as DIRACGrid/intercede#43.

  • pre-commit: zizmor hook (--no-progress --no-online-audits; args replaces the hook's own args, so --no-progress is kept).
  • CI: a pre-commit workflow runs the hooks on PRs and pushes to main, same as intercede and signurlarity, so the audit is enforced and not only run by local installs.
  • pr-review-reminder.yml brought zizmor-clean with the auditor persona (zizmor --persona=auditor):
    • actions/github-script pinned to commit SHA (unpinned-uses)
    • workflow permissions reduced to contents: read (excessive-permissions)
    • concurrency group (concurrency-limits) and job name (anonymous-definition)
  • One documented suppression: MATTERMOST_WEBHOOK (secrets-outside-env): notification-only webhook, no GitHub environment needed.

zizmor v1.32.0 reports no findings on this branch's workflows with the default and the auditor persona, online audits included.

Not in this PR: Renovate does not bump pre-commit hooks by default (its pre-commit manager is opt-in), and this repo has no renovate.json yet, so these pins and the zizmor rev are not updated automatically. That is a follow-up on the shared preset.

- Add a pre-commit workflow (same shape as intercede/signurlarity), so the
  zizmor hook is enforced on PRs instead of only for local installs.
- Use python3 instead of python3.11: the runner (setup-python 3.x) and many
  laptops have no python3.11, so the hook failed to install.
- Keep the hook's own --no-progress: `args` replaces the hook's args.
- Comment the github-script pin with its exact version (v7.1.0).

Assisted-by: Claude:claude-opus-5-5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants