Repository navigation
Conversation
fstagni
marked this pull request as ready for review
November 15, 2026 14:17
fstagni
force-pushed
the
zizmor-auditor
branch
from
November 16, 2026 09:33
5ad4bf6 to
2bb38c7
Compare
fstagni
force-pushed
the
zizmor-auditor
branch
from
November 16, 2026 09:51
2bb38c7 to
ec1596b
Compare
- Add a pre-commit workflow (same shape as intercede/signurlarity), so the zizmor hook is enforced on PRs instead of only for local installs. - Use python3 instead of python3.11: the runner (setup-python 3.x) and many laptops have no python3.11, so the hook failed to install. - Keep the hook's own --no-progress: `args` replaces the hook's args. - Comment the github-script pin with its exact version (v7.1.0). Assisted-by: Claude:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #5 (add
zizmoreverywhere as pre-commit), same as DIRACGrid/intercede#43.--no-progress --no-online-audits;argsreplaces the hook's own args, so--no-progressis kept).pre-commitworkflow runs the hooks on PRs and pushes tomain, same as intercede and signurlarity, so the audit is enforced and not only run by local installs.pr-review-reminder.ymlbrought zizmor-clean with the auditor persona (zizmor --persona=auditor):actions/github-scriptpinned to commit SHA (unpinned-uses)permissionsreduced tocontents: read(excessive-permissions)MATTERMOST_WEBHOOK(secrets-outside-env): notification-only webhook, no GitHub environment needed.zizmor v1.32.0reports no findings on this branch's workflows with the default and the auditor persona, online audits included.Not in this PR: Renovate does not bump pre-commit hooks by default (its
pre-commitmanager is opt-in), and this repo has norenovate.jsonyet, so these pins and the zizmorrevare not updated automatically. That is a follow-up on the shared preset.