Skip to content

fix(statements): comma times, footer rows, unplaced-time message, restore token (#57) - #246

Open
JOY (JOY) wants to merge 5 commits into
devfrom
claude/57-restore-token
Open

JOY (JOY) wants to merge 5 commits into
devfrom
claude/57-restore-token

Conversation

@JOY

@JOY JOY (JOY) commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Refs #57

Last follow-up from the PO's Money re-check of #245 (merged as bfc2a44). It needs DOS/DOS.Me's 20261122110000_give_statement_restore_token. The Give Product Owner merges.

  • A time right after a colon or comma that follows a word ("Giờ/Time:14:30", "Khung giờ,14:30") now counts too. The period's own time may follow a comma, so "15/11/2026, 23:59" is a full day.
  • Comma before a time. A comma or dot right after a date is now removed together with the date. So "15/11/2026,14:30" on the period row, and "Giờ/Time: 01/11/2026,08:00 - 15/11/2026,14:30", are read as times and the file is refused.
  • Footer rows. Rows after the table are checked for times the same way as the rows above it. For example, ["Điều kiện lọc", "08:00-14:30"] makes the file partial, while a print time in the footer is fine.
  • Distinct message. A file refused only because of a time the parser cannot place (a time filter, or a name like "CÔNG TY 4G") gets coverageDetail: "unplaced_time" and the code STATEMENT_COVERAGE_UNCLEAR. Its message tells the uploader to export again only if they filtered by time, and otherwise to send the file to finance. A missing period or a start after midnight keeps STATEMENT_PARTIAL_EXPORT.
  • Restore token. The restore form passes last_rejected_row_id.
  • The false refusals stay for tuning against real Techcombank samples, as the PO decided.

Fresh-context review: round 1 found one MUST_FIX (a time right after a colon or comma), fixed in d9e80ec; round 2 clean.

Locally 1910 tests, tsc, lint and build pass. Two heavy pipeline tests can exceed their 20-second inline budget only under machine load; they pass when run alone.

🤖 Generated with Claude Code

…r unplaced times, restore token (#57)

- A comma or dot right after a date goes with it, so '15/11/2026,14:30'
  reads as a time.
- Rows after the table are checked for times as the rows above it are.
- A file refused for a time the parser cannot place (maybe a name like
  '4G') gets STATEMENT_COVERAGE_UNCLEAR, which says to contact finance
  rather than only to export again.
- The restore names the latest rejected row (last_rejected_row_id).

Needs DOS.Me migration 20261122110000_give_statement_restore_token.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@JOY JOY (JOY) added the line:money Product line: money label Nov 18, 2026
@vercel

vercel Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
give Ready Ready Preview Nov 18, 2026 4:14pm UTC

Request Review

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization has no extra usage available to pay for this review.

If your organization's extra usage balance is empty, an organization admin can add extra usage credits at claude.ai/admin-settings/usage. If its monthly spend limit was reached, an admin can raise it on the same page. If neither applies, contact Anthropic support.

Once extra usage is available, someone with write access to this repository can comment @claude review on this pull request to trigger a review.

@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 635e33f1-f903-4fba-907f-baeaedf3caca

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

dos[bot]
dos Bot approved these changes Nov 18, 2026

@dos dos Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⏱️ Code Review completed (12 eligible files · 18,208 chars · 1 model call(s) · 1 PR unit(s))

Whole diff with bounded context at base bfc2a44 / head 54630fc.

✅ CLEAN_PASS: Complete diff reviewed

…may precede the period's own time (#246 review)

Co-Authored-By: Claude Opus 5.5 <[email protected]>
dos[bot]
dos Bot approved these changes Nov 18, 2026

@dos dos Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⏱️ Code Review completed (12 eligible files · 21,160 chars · 2 model call(s) · 1 PR unit(s))

Whole diff with bounded context at base bfc2a44 / head d9e80ec.

✅ CLEAN_PASS: Complete diff reviewed

Context investigation was bounded to the explicitly requested snapshot paths.

…check)

- A cell that reads as an amount ('0.00', '1,500,000.00') and a summary
  line ('Tổng phí/Total fees') are not scanned for times, so a full export
  with zero-decimal totals is no longer refused.
- Print labels: 'Thời gian in báo cáo', 'Printed date'.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
dos[bot]
dos Bot approved these changes Nov 18, 2026

@dos dos Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⏱️ Code Review completed (12 eligible files · 24,172 chars · 1 model call(s) · 1 PR unit(s))

Whole diff with bounded context at base bfc2a44 / head ced1358.

✅ CLEAN_PASS: Complete diff reviewed

…s count; print labels in the footer (#246 review)

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@dos

dos Bot commented Nov 18, 2026

Copy link
Copy Markdown

⏸️ DOS Review: Automatic Review Limit Reached

DOS Code Review already reviewed 3 commits of this pull request automatically, the limit for one pull request, so this commit was not reviewed automatically and nothing was charged. Please step back before pushing another fix: a pull request that needs this many review rounds usually needs a rethink of its approach or a smaller scope, not one more patch. When you are ready, a maintainer can comment /review to review the current commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

line:money Product line: money

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant