Repository navigation
Conversation
…r unplaced times, restore token (#57) - A comma or dot right after a date goes with it, so '15/11/2026,14:30' reads as a time. - Rows after the table are checked for times as the rows above it are. - A file refused for a time the parser cannot place (maybe a name like '4G') gets STATEMENT_COVERAGE_UNCLEAR, which says to contact finance rather than only to export again. - The restore names the latest rejected row (last_rejected_row_id). Needs DOS.Me migration 20261122110000_give_statement_restore_token. Co-Authored-By: Claude Opus 5.5 <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
If your organization's extra usage balance is empty, an organization admin can add extra usage credits at claude.ai/admin-settings/usage. If its monthly spend limit was reached, an admin can raise it on the same page. If neither applies, contact Anthropic support.
Once extra usage is available, someone with write access to this repository can comment @claude review on this pull request to trigger a review.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
…may precede the period's own time (#246 review) Co-Authored-By: Claude Opus 5.5 <[email protected]>
…check)
- A cell that reads as an amount ('0.00', '1,500,000.00') and a summary
line ('Tổng phí/Total fees') are not scanned for times, so a full export
with zero-decimal totals is no longer refused.
- Print labels: 'Thời gian in báo cáo', 'Printed date'.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
…s count; print labels in the footer (#246 review) Co-Authored-By: Claude Opus 5.5 <[email protected]>
⏸️ DOS Review: Automatic Review Limit ReachedDOS Code Review already reviewed 3 commits of this pull request automatically, the limit for one pull request, so this commit was not reviewed automatically and nothing was charged. Please step back before pushing another fix: a pull request that needs this many review rounds usually needs a rethink of its approach or a smaller scope, not one more patch. When you are ready, a maintainer can comment /review to review the current commit. |
…alance lines (#246 review) Co-Authored-By: Claude Opus 5.5 <[email protected]>
Refs #57
Last follow-up from the PO's Money re-check of #245 (merged as bfc2a44). It needs DOS/DOS.Me's
20261122110000_give_statement_restore_token. The Give Product Owner merges."15/11/2026,14:30"on the period row, and"Giờ/Time: 01/11/2026,08:00 - 15/11/2026,14:30", are read as times and the file is refused.["Điều kiện lọc", "08:00-14:30"]makes the file partial, while a print time in the footer is fine.coverageDetail: "unplaced_time"and the codeSTATEMENT_COVERAGE_UNCLEAR. Its message tells the uploader to export again only if they filtered by time, and otherwise to send the file to finance. A missing period or a start after midnight keepsSTATEMENT_PARTIAL_EXPORT.last_rejected_row_id.Fresh-context review: round 1 found one MUST_FIX (a time right after a colon or comma), fixed in d9e80ec; round 2 clean.
Locally 1910 tests, tsc, lint and build pass. Two heavy pipeline tests can exceed their 20-second inline budget only under machine load; they pass when run alone.
🤖 Generated with Claude Code