Skip to content

fix(web): guard sold-out strip, 0-review tag and JSON-LD - #1740

Open
JOY (JOY) wants to merge 2 commits into
devfrom
fix/1732-pdv-sold-out-strip-jsonld-truth
Open

JOY (JOY) wants to merge 2 commits into
devfrom
fix/1732-pdv-sold-out-strip-jsonld-truth

Conversation

@JOY

@JOY JOY (JOY) commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Gate <PriceWatchButton> behind minPrice > 0 and require lowestEverPrice != null && lowestEverPrice > 0 before rendering allTimeLowBadge in both ProductDetailView (smartphones/[slug]/page.tsx) and ItemSizePriceStrip (ItemLazySizePanel.tsx).
  • Omit empty image arrays on Product and ProductGroup JSON-LD nodes (and trim retained URLs), omit hasVariant when no variant has finite minPrice > 0, and clamp priced variant offerCount to >= 1 (highPrice >= lowPrice) in buildItemProductGroupNode (item-page.ts).
  • Suppress the green authenticReviewsBadge scoreboard tag when authenticCount <= 0, point price-strip history audit links to #pdv-price-history, and add aria-hidden="true" to the decorative <BsTrophyFill /> icon in ProductLeaderboardBadges.tsx.
  • Add unit and SSR markup regression tests in apps/web/src/server/rate/__tests__/item-model.test.ts (including NaN/Infinity variant bounds and sold-out strips with positive historical lows).

Verification

  • pnpm --filter @repo/web test
  • pnpm --filter @repo/web typecheck
  • pnpm --filter @repo/web lint
  • pnpm --filter @repo/web build
  • Fresh-context subagent diff review (Round 1: 0 P0, 0 P1, 1 P2 URL trim + 1 P3 edge-case tests, both fixed in e1e052b7)
  • codex review --base origin/dev on e1e052b7 (0 findings)

Closes #1732
Claimant: qwen:Rate-a4-a46dfc

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization has no extra usage available to pay for this review.

If your organization's extra usage balance is empty, an organization admin can add extra usage credits at claude.ai/admin-settings/usage. If its monthly spend limit was reached, an admin can raise it on the same page. If neither applies, contact Anthropic support.

Once extra usage is available, someone with write access to this repository can comment @claude review on this pull request to trigger a review.

@vercel

vercel Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
rate Ready Ready Preview Nov 18, 2026 3:19pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 17 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c3bc78d6-316f-4f33-a650-ca6813dbf80b
Commits

Reviewing files that changed from the base of the PR and between 4760fb6 and e1e052b.

Files selected for processing: 5

  • apps/web/src/app/[locale]/smartphones/[slug]/page.tsx
  • apps/web/src/components/leaderboard/ProductLeaderboardBadges.tsx
  • apps/web/src/components/product/item/ItemLazySizePanel.tsx
  • apps/web/src/lib/item-page.ts
  • apps/web/src/server/rate/__tests__/item-model.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions github-actions Bot added the area:frontend Frontend / Next.js / UI label Nov 18, 2026
dos[bot]
dos Bot approved these changes Nov 18, 2026

@dos dos Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⏱️ Code Review completed (5 eligible files · 16,824 chars · 2 model call(s) · 1 PR unit(s))

Whole diff with bounded context at base b7f6dcc / head 81a66fc.

✅ CLEAN_PASS: Complete diff reviewed

Context investigation was bounded to the explicitly requested snapshot paths.

dos[bot]
dos Bot approved these changes Nov 18, 2026

@dos dos Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⏱️ Code Review completed (5 eligible files · 17,920 chars · 2 model call(s) · 1 PR unit(s))

Whole diff with bounded context at base b7f6dcc / head e1e052b.

✅ CLEAN_PASS: Complete diff reviewed

Context investigation was bounded to the explicitly requested snapshot paths.

This branch was successfully deployed

1 active deployment
Preview — e1e052b7 Deployed Nov 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:frontend Frontend / Next.js / UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(web): guard sold-out price strip and 0-review tag and harden Product and ProductGroup JSON-LD

1 participant