Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #189 — Prepare DataFog 4.12 release with Core 1.5. The approved version plan uses Core 1.5.0 and Python 4.12.0. This Core 2 draft and its artifact qualification are retained below as review history and must not be used for publication.
Prepare the dependent 4.12.0 release with
datafog-core~=2.0.0in both the base package andrustextra. Current documentation points to the reviewed Core 2 contract, and release notes explain the resulting detection fixes, preserved plain-hash defaults, explicit HMAC and the first-output latency from buffered streaming.Stacked on #187. Merge remains blocked until Core 2.0.0 is published and this Python candidate passes installed-wheel and release qualification against the actual published Core artifacts. Keep this PR as a draft until that gate passes. This change publishes no package and creates no release tags. Source-wheel integration is additional evidence and does not replace published-artifact qualification.
Validation of candidate
43363a6581253cc7150c2aa5bbf267df78fddc5eon Python 3.12: built a fresh wheel, installed it with the local Core 2.0.0 wheel, passedpip checkandpython -I scripts/check_rust_install.py, then ran the complete non-slow suite against the installed package using isolated Python and pytest importlib mode: 1,138 passed, 21 skipped, 295 deselected and 19 xfailed. Optional model/OCR/Spark profiles were not provisioned for this isolated run. All applicable pre-commit hooks passed, and packageddatafog/bytes match the committed candidate source.Candidate artifact identities:
8bffc65e4613ab881dcff7b4ac337c9fd6b52ab253ebf3c9e2fb82223a98a6470d2d8fc83d1bc8a5a7b1ea8d1852c213f035b88ea9f78ad78a3eaa1d51cce09fAfter #187 merges, retarget this PR to the development branch and qualify it against the published Core release before merging.