Skip to content

Fix dead Electron locales link in GetLocaleAsync docs - #1130

Merged
FlorianRappl merged 1 commit into
ElectronNET:developfrom
farisbasha:docs/fix-locales-link
Nov 18, 2026
Merged

FlorianRappl merged 1 commit into
ElectronNET:developfrom
farisbasha:docs/fix-locales-link

Conversation

@farisbasha

Copy link
Copy Markdown

The GetLocaleAsync docs (both docs/API/App.md and the XML doc comment in App.cs) link to https://www.electronjs.org/docs/api/locales, which no longer exists: it redirects to /docs/latest/api/locales, which returns 404.

This points the link at the app.getLocale() section of the Electron app API docs (https://www.electronjs.org/docs/latest/api/app#appgetlocale), which is where Electron now documents the possible return values.

Checked with curl -I: the new URL returns 200 without a redirect.

The electronjs.org/docs/api/locales page no longer exists (404). Link
to the app.getLocale() section of the Electron app API docs instead,
which documents the possible return values.

@FlorianRappl FlorianRappl left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@FlorianRappl FlorianRappl added this to the 1.0.0 milestone Nov 18, 2026
@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

pr-comment: Run #168

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
1560 1334 88 0 0 138 0 4m 59s

❌ Some tests failed!

Name Failure Message
❌ MenuTests - ApplicationMenu_click_invokes_handler System.TimeoutException : The Electron process did not start within 10 seconds
❌ AppTests - BadgeCount_set_and_reset_where_supported System.TimeoutException : The Electron process did not start within 10 seconds
❌ IpcMainTests - Ipc_Once_only_fires_once System.TimeoutException : The Electron process did not start within 10 seconds
❌ SessionTests - Session_preloads_set_multiple_and_clear System.TimeoutException : The Electron process did not start within 10 seconds
❌ BrowserWindowTests - Menu_bar_visibility_and_auto_hide System.TimeoutException : The Electron process did not start within 10 seconds

See all failed tests here

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

@FlorianRappl
FlorianRappl merged commit 68870f4 into ElectronNET:develop Nov 18, 2026
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants