Repository navigation
Fix dead Electron locales link in GetLocaleAsync docs - #1130
Merged
FlorianRappl merged 1 commit intoNov 18, 2026
Merged
Conversation
The electronjs.org/docs/api/locales page no longer exists (404). Link to the app.getLocale() section of the Electron app API docs instead, which documents the possible return values.
pr-comment: Run #168
❌ Some tests failed!
Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
GetLocaleAsyncdocs (bothdocs/API/App.mdand the XML doc comment inApp.cs) link tohttps://www.electronjs.org/docs/api/locales, which no longer exists: it redirects to/docs/latest/api/locales, which returns 404.This points the link at the
app.getLocale()section of the Electron app API docs (https://www.electronjs.org/docs/latest/api/app#appgetlocale), which is where Electron now documents the possible return values.Checked with
curl -I: the new URL returns 200 without a redirect.