Skip to content

USD/PointInstancer fixes - #1576

Merged
johnhaddon merged 1 commit into
ImageEngine:RB-10.7from
johnhaddon:pointInstancerFixes
Nov 6, 2026
Merged

johnhaddon merged 1 commit into
ImageEngine:RB-10.7from
johnhaddon:pointInstancerFixes

Conversation

@johnhaddon

Copy link
Copy Markdown
Member

Fixes to deal with some slightly oddball instancers we encountered in production.

@johnhaddon johnhaddon self-assigned this Nov 4, 2026
@johnhaddon
johnhaddon force-pushed the pointInstancerFixes branch 2 times, most recently from cca2815 to c96b76f Compare November 4, 2026 17:00

@murraystevenson murraystevenson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks John! One question about the Changes entry, but otherwise this looks good to merge.

Comment thread Changes Outdated
Fixes
-----

- USD : Fixed loading when a `primvars:*` attribute conflicts with a primitive variable loaded from a schema attribute, for instance `PointBased.positions`. The schema attribute now takes precedence and a warning is emitted.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PointBased.positions - Are we conflating PointBased.points and PointInstancer.positions here? I find it hard to keep these straight in my head...

@johnhaddon

Copy link
Copy Markdown
Member Author

As discussed yesterday, I've dropped the primvar loading commit, and will reintroduce that in a PR to main. Merging.

@johnhaddon
johnhaddon merged commit c0ae475 into ImageEngine:RB-10.7 Nov 6, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants