Repository navigation
USD/PointInstancer fixes - #1576
Merged
Merged
Conversation
johnhaddon
force-pushed
the
pointInstancerFixes
branch
2 times, most recently
from
November 4, 2026 17:00
cca2815 to
c96b76f
Compare
murraystevenson
left a comment
Collaborator
There was a problem hiding this comment.
Thanks John! One question about the Changes entry, but otherwise this looks good to merge.
| Fixes | ||
| ----- | ||
|
|
||
| - USD : Fixed loading when a `primvars:*` attribute conflicts with a primitive variable loaded from a schema attribute, for instance `PointBased.positions`. The schema attribute now takes precedence and a warning is emitted. |
Collaborator
There was a problem hiding this comment.
PointBased.positions - Are we conflating PointBased.points and PointInstancer.positions here? I find it hard to keep these straight in my head...
johnhaddon
force-pushed
the
pointInstancerFixes
branch
from
November 6, 2026 09:19
c96b76f to
3b7db50
Compare
Member
Author
|
As discussed yesterday, I've dropped the primvar loading commit, and will reintroduce that in a PR to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes to deal with some slightly oddball instancers we encountered in production.