Repository navigation
feat: parse PostgreSQL metadata object DDL - #2931
Merged
manticore-projects merged 1 commit intoNov 15, 2026
Merged
manticore-projects merged 1 commit into
manticore-projects merged 1 commit into
Conversation
Add typed language, large-object ownership and text-search metadata statements with visitor, deparser and validation integration. Reuse structured definition arguments and preserve ordered duplicate options with last-value accessors matching PostgreSQL. Cover syntax variants, rejected forms, statement boundaries, AST fields, OID traversal and existing unsupported-statement fallback behavior.
Contributor
|
thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL language, large-object ownership and several text-search DDL commands
were returned as UnsupportedStatement. Add typed statement models for:
VALIDATOR/NO VALIDATOR and the handlerless form; ALTER [PROCEDURAL] LANGUAGE
RENAME/OWNER.
using the existing DefinitionElement/DefinitionArgument model, including quoted
keys, string/number values, qualified function names and dictionary option removal.
Wire the new types into statement visitors, deparsing, feature analysis
(MODIFIES_SCHEMA), table discovery and validation capabilities. The OID expression
participates in expression traversal and custom deparsing. Parser/template ALTER
models expose rename/schema changes; dictionary ALTER also supports ownership and
option changes. Repeated definitions retain their order; convenience getters expose the last value,
matching PostgreSQL. No new reserved keywords are introduced.
References: PostgreSQL CREATE LANGUAGE,
ALTER LARGE OBJECT,
DICTIONARY,
PARSER,
TEMPLATE.
Validation:
./gradlew check jar: PASS; 16,563 tests, zero failures/errors,25 existing skips. New metadata regression class: 98/98 PASS. Initial clean
generation, grammar ambiguity, Checkstyle, PMD, SpotBugs, Spotless and coverage
verification all pass. An external init script caps heaps and pins the formatter
ratchet to f880f35 without changing repository build configuration.
grammar ambiguity and Codacy pass. Maven Verify passes on Linux; the Windows/macOS jobs are still running.
All twenty-six deparser outputs execute successfully on PostgreSQL 18.6 with
synthetic fixtures, transaction rollback and catalog postchecks.
observations). It preserves every previously parsed observation and changes the targeted unsupported commands into
their concrete statement types.
Known limit: binary/octal OID literals (0b/0o prefixes) still need shared lexer
support. The existing decimal and hexadecimal tokens are reused without changing the shared lexer.
AI assistance: prepared with OpenAI Codex.