Repository navigation
Let load! append when source column names differ only in case - #381
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #381 +/- ##
==========================================
- Coverage 96.90% 96.89% -0.01%
==========================================
Files 5 5
Lines 808 806 -2
==========================================
- Hits 783 781 -2
Misses 25 25 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Opus 5.5 <[email protected]>
SQLite compares column names without regard to case, and checkdupnames already does. checknames compared them exactly, so load! rejected a source column NAME for a table column name. Co-Authored-By: Claude Opus 5.5 <[email protected]>
quinnj-bot
Bot
force-pushed
the
claude/load-names-ignore-case
branch
from
November 16, 2026 19:57
7d4d059 to
05a2698
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Appending to an existing table with
SQLite.load!failed when a source column name differed from the table's only in case. A DataFrame with aNAMEcolumn could not be loaded into a table with anamecolumn:Error loading, column names from table ["Id", "NAME"] do not match database names ["name", "id"]. SQLite itself treats column names without regard to case, so theINSERTwould have worked.load!'s own duplicate-name check already ignores case.What changed
Scope
lowercasefolds non-ASCII letters too, while SQLite folds only ASCII. A pair such asÉ/énow passes this check and fails at theINSERTwith SQLite's "no such column" error instead. The duplicate-name check already behaves this way.Verification
load! matches existing column names ignoring case. On master it errors with the message above; on this branch it passes 2/2, including a misspelled name that still throws.Pkg.test()passes on Julia 1.12 and 1.10 (525/525).🤖 Generated with Claude Code