Repository navigation
chore(otp): remove the disabled OTP auto-fill code - #827
Merged
Merged
Conversation
The notification listener was disabled in beta-430-1 to avoid Play Protect blocking the sideloaded APK, and nothing reaches the code any more. Removes the service, the suggestion manager, the SMS package helper, the permission helpers, the settings values and the strings (all locales), the commented manifest entry and settings code, and the docs for the feature. The suggestion layout was shared with the calculator suggestion, so it is renamed to inline_suggestion and its close button is labeled with the generic close string instead of "Dismiss OTP suggestion".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The OTP notification listener was disabled in beta-430-1 (d215e07) because Play Protect blocked sideloaded APKs that declare
BIND_NOTIFICATION_LISTENER_SERVICE. Its code stayed in the tree. This removes it:OtpNotificationListenerService,OtpSuggestionManager,SmsPackageProviderand the unit testPermissionsUtil(checkAllPermissionsGrantedstays)PREF_AUTO_READ_OTP,PREF_ENABLE_SMS_OTP_RECEIVERand theirSettingsValuesfieldsauto_read_otp,auto_read_otp_summary,spoken_otp_suggestionin all localesNotes
otp_suggestion.xmlwas also used by the calculator suggestion, so it is renamed toinline_suggestion.xmland its close button now usesdialog_closeinstead of "Dismiss OTP suggestion".auto_read_otpvalues in existing users' preferences are harmless leftovers.assembleStandardDebugandcompileOfflineRunTestsKotlin.