Skip to content

chore(otp): remove the disabled OTP auto-fill code - #827

Merged
LeanBitLab merged 1 commit into
mainfrom
chore/remove-dead-otp
Nov 15, 2026
Merged

LeanBitLab merged 1 commit into
mainfrom
chore/remove-dead-otp

Conversation

@LeanBitLab

Copy link
Copy Markdown
Owner

What

The OTP notification listener was disabled in beta-430-1 (d215e07) because Play Protect blocked sideloaded APKs that declare BIND_NOTIFICATION_LISTENER_SERVICE. Its code stayed in the tree. This removes it:

  • OtpNotificationListenerService, OtpSuggestionManager, SmsPackageProvider and the unit test
  • the notification listener helpers in PermissionsUtil (checkAllPermissionsGranted stays)
  • PREF_AUTO_READ_OTP, PREF_ENABLE_SMS_OTP_RECEIVER and their SettingsValues fields
  • the commented manifest entry and the commented settings code
  • the strings auto_read_otp, auto_read_otp_summary, spoken_otp_suggestion in all locales
  • the feature docs (README bullet, FEATURES index/summary rows and section 17; later sections keep their numbers so existing anchors still work)

Notes

  • otp_suggestion.xml was also used by the calculator suggestion, so it is renamed to inline_suggestion.xml and its close button now uses dialog_close instead of "Dismiss OTP suggestion".
  • Old auto_read_otp values in existing users' preferences are harmless leftovers.
  • Clipboard OTP/card filtering is a different feature and is untouched.
  • Builds with assembleStandardDebug and compileOfflineRunTestsKotlin.

The notification listener was disabled in beta-430-1 to avoid Play Protect blocking the
sideloaded APK, and nothing reaches the code any more. Removes the service, the suggestion
manager, the SMS package helper, the permission helpers, the settings values and the
strings (all locales), the commented manifest entry and settings code, and the docs for
the feature.

The suggestion layout was shared with the calculator suggestion, so it is renamed to
inline_suggestion and its close button is labeled with the generic close string instead of
"Dismiss OTP suggestion".
@LeanBitLab
LeanBitLab merged commit eaab5a0 into main Nov 15, 2026
1 check passed
@LeanBitLab
LeanBitLab deleted the chore/remove-dead-otp branch November 15, 2026 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant