Repository navigation
fix(lint): dead SDK checks, intersect result, service leak, explicit locale - #835
Merged
Merged
Conversation
Behavior is unchanged, numbers are still formatted for the device locale.
…atic service reference - drop SDK_INT checks that are always true with minSdk 23 - Rect.intersect leaves the rect unclipped when there is no overlap, so empty it (FloatingKeyboardManager, LatinIME touchable region) - AccessibilityUtils is a static singleton and held the LatinIME service, keep the application context instead - suppress StaticFieldLeak where the singleton already holds the application context - CustomSoundManager: BLE broadcast devices need API 33, not 31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Not included (separate follow-ups): `ClickableViewAccessibility`, stale translations, unused resources.
Verification