Skip to content

fix(lint): suppress ClickableViewAccessibility on gesture-only touch handlers - #838

Merged
LeanBitLab merged 1 commit into
mainfrom
fix/lint-clickable-view-accessibility
Nov 15, 2026
Merged

LeanBitLab merged 1 commit into
mainfrom
fix/lint-clickable-view-accessibility

Conversation

@LeanBitLab

Copy link
Copy Markdown
Owner

Summary

  • Add `@SuppressLint("ClickableViewAccessibility")` with a one-line reason at 10 sites (13 lint warnings): `EmojiPalettesView`, `SuggestionStripView`, `ClipboardHistoryView`, `EmojiTabStripScrollView`, `HandwritingCanvas`, `OcrCameraView`, `TouchpadView`.
  • These touch listeners and `onTouchEvent` overrides handle scroll locking, caret placement, key repeat, drawing and tap-to-focus, none of them is a click target. Calling `performClick()` there would fire click listeners and could double-trigger actions, so the check is suppressed instead.
  • Annotations only, no logic change.

Verification

  • `./gradlew :app:assembleStandardDebug` passes
  • `lintStandardDebug`: 0 errors, ClickableViewAccessibility 13 -> 0 (warnings 210 -> 197)

…handlers

These touch listeners and onTouchEvent overrides handle scroll locking, caret
placement, key repeat, drawing and tap-to-focus, none of them is a click target.
Calling performClick() there would fire click listeners and change behavior, so
suppress the check with a reason at each site instead.
@LeanBitLab
LeanBitLab merged commit 359bf23 into main Nov 15, 2026
1 check passed
@LeanBitLab
LeanBitLab deleted the fix/lint-clickable-view-accessibility branch November 15, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant