Repository navigation
fix(cjk): reapply engine locale after session destroy or engine reload - #844
Merged
Merged
Conversation
CjkInputManager cached the last locale sent to the engine and skipped setLocale when unchanged. destroySession() on finishing the input view (app switch) and engine reloads reset the engine to its default locale, so Japanese input fell back to Chinese Pinyin until the keyboard was restarted. Clear the cache on finish and track the engine instance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Japanese input falls back to Chinese Pinyin after switching apps (reported on a physical keyboard). Restarting the keyboard or reinstalling the plugin fixes it only temporarily.
Cause
CjkInputManagercaches the last locale sent to the engine (activeLocale) and only callssetLocalewhen it changes.destroySession()(called fromonFinishInputViewon app switch) and engine reloads reset the engine to its default locale (zh), but the cache still saysja, so the locale is never re-sent.Fix
activeLocaleafterdestroySession()inonFinishInputView.Notes
:app:compileStandardDebugKotlin; not yet tested on device.