Skip to content

fix(spacebar,emoji): spacebar text on bottom rows, incognito icon placement, sub-category swipe - #846

Merged
LeanBitLab merged 5 commits into
mainfrom
fix/spacebar-text-and-incognito-indicator
Nov 16, 2026
Merged

LeanBitLab merged 5 commits into
mainfrom
fix/spacebar-text-and-incognito-indicator

Conversation

@LeanBitLab

@LeanBitLab LeanBitLab commented Nov 16, 2026 •

Copy link
Copy Markdown
Owner

Changes

  1. Custom space bar text missing on clipboard/emoji pages. Only KeyboardSwitcher called startDisplayLanguageOnSpacebar, so the bottom-row MainKeyboardViews of the clipboard and emoji pages kept the NONE format type. The format type is now set in MainKeyboardView.setKeyboard. Those rows now also show the language name when no custom text is set, same as the main keyboard.
  2. Incognito indicator on the space bar. The icon is sized from the key height (65%) and drawn at full strength. With language text it sits right before the text (the text gets less room, and is dropped if the key is too narrow, e.g. the numpad, leaving the centered icon). Without language text it is a centered badge instead of a 15% alpha watermark.
  3. Emoticon/unicode sub-category swipe switching the whole emoji category. The listener that blocks ViewPager2 interception is attached to the chips as well as the strip, and it only sets the disallow flag. Clearing it on ACTION_CANCEL re-enabled the pager when the strip took over a drag that started on a chip. The margin between chips is removed so no swipe starts in a dead gap.

Testing

  • Compiles; checked on device with a debug build (spacebar text on clipboard/emoji, incognito indicator, chip swiping).

The icon was pinned to the right edge at 15% alpha and could overlap the
text on narrow space keys such as the numpad. With language text shown it
now sits right before the text (sized from the text height), and falls
back to the centered watermark when the key is too narrow for any text.
…ottom rows

Only KeyboardSwitcher called startDisplayLanguageOnSpacebar, so the bottom
row views of the clipboard and emoji pages kept the NONE format type and
never drew the custom space bar text. Set it in MainKeyboardView.setKeyboard.
…tegory

The listener that blocks ViewPager2 interception was only set on the chip
strip, so it never ran for touches that start on a chip (the chip consumes
DOWN). Attach it to the chips as well.
Size the icon from the key height (65%) and draw it at full strength, both
beside the language text and when no text is shown. The faint 15% alpha
watermark was easy to miss, and the text-relative size was too small for
multi-language setups.
…egory

The pager-blocking listener cleared the disallow-intercept flag on
ACTION_CANCEL. When the strip takes over a drag that starts on a chip, the
chip gets a CANCEL, which re-enabled the pager and let it take the swipe.
Only set the flag (the framework resets it on every new touch), and remove
the margin between chips so no swipe starts in a dead gap.
@LeanBitLab
LeanBitLab merged commit 68e9a8f into main Nov 16, 2026
1 check passed
@LeanBitLab
LeanBitLab deleted the fix/spacebar-text-and-incognito-indicator branch November 16, 2026 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant