Repository navigation
fix(spacebar,emoji): spacebar text on bottom rows, incognito icon placement, sub-category swipe - #846
Merged
Conversation
The icon was pinned to the right edge at 15% alpha and could overlap the text on narrow space keys such as the numpad. With language text shown it now sits right before the text (sized from the text height), and falls back to the centered watermark when the key is too narrow for any text.
…ottom rows Only KeyboardSwitcher called startDisplayLanguageOnSpacebar, so the bottom row views of the clipboard and emoji pages kept the NONE format type and never drew the custom space bar text. Set it in MainKeyboardView.setKeyboard.
…tegory The listener that blocks ViewPager2 interception was only set on the chip strip, so it never ran for touches that start on a chip (the chip consumes DOWN). Attach it to the chips as well.
Size the icon from the key height (65%) and draw it at full strength, both beside the language text and when no text is shown. The faint 15% alpha watermark was easy to miss, and the text-relative size was too small for multi-language setups.
…egory The pager-blocking listener cleared the disallow-intercept flag on ACTION_CANCEL. When the strip takes over a drag that starts on a chip, the chip gets a CANCEL, which re-enabled the pager and let it take the swipe. Only set the flag (the framework resets it on every new touch), and remove the margin between chips so no swipe starts in a dead gap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
KeyboardSwitchercalledstartDisplayLanguageOnSpacebar, so the bottom-rowMainKeyboardViews of the clipboard and emoji pages kept the NONE format type. The format type is now set inMainKeyboardView.setKeyboard. Those rows now also show the language name when no custom text is set, same as the main keyboard.ViewPager2interception is attached to the chips as well as the strip, and it only sets the disallow flag. Clearing it onACTION_CANCELre-enabled the pager when the strip took over a drag that started on a chip. The margin between chips is removed so no swipe starts in a dead gap.Testing