Skip to content

fix(updates): derive update indicator from installed vs latest version - #849

Merged
LeanBitLab merged 1 commit into
mainfrom
fix/updates-indicator-stale
Nov 16, 2026
Merged

LeanBitLab merged 1 commit into
mainfrom
fix/updates-indicator-stale

Conversation

@LeanBitLab

Copy link
Copy Markdown
Owner

Problem

The update indicator (red dot on the Updates entry and the per-plugin state) was out of sync until the user tapped check for updates:

  • after updating a plugin the dot stayed on, so it looked like the plugin was not updated
  • a plugin installed after the last check showed no update state
  • the automatic check only runs every 7 days by default

Cause

PREF_APP_UPDATE_AVAILABLE and PREF_PLUGIN_UPDATE_PREFIX* were booleans written only by checkAllUpdates, and only installed plugins were looked up.

Fix

  • hasAppUpdate, isPluginUpdateAvailable and getInstalledPluginStatuses compare the cached latest tag with the current installed version at read time
  • checkAllUpdates caches the latest tag of every plugin, not only installed ones
  • removed the two stored boolean prefs

Notes

  • A release published after the last automatic check still needs the next check (7 days by default) or a manual check
  • The main settings badge now reads installed plugin versions at composition (the Updates screen already did)

Testing

  • ./gradlew :app:compileStandardDebugKotlin passes
  • Not yet checked on a device

The update flags were booleans written only by a check, so they stayed on
after a plugin was updated and were missing for plugins installed after the
last check. Derive them at read time from the cached latest tag and the
current installed version, and cache the latest tag of every plugin.
@LeanBitLab
LeanBitLab merged commit 8cf5248 into main Nov 16, 2026
1 check passed
@LeanBitLab
LeanBitLab deleted the fix/updates-indicator-stale branch November 16, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant