Repository navigation
fix(updates): derive update indicator from installed vs latest version - #849
Merged
Merged
Conversation
The update flags were booleans written only by a check, so they stayed on after a plugin was updated and were missing for plugins installed after the last check. Derive them at read time from the cached latest tag and the current installed version, and cache the latest tag of every plugin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The update indicator (red dot on the Updates entry and the per-plugin state) was out of sync until the user tapped check for updates:
Cause
PREF_APP_UPDATE_AVAILABLEandPREF_PLUGIN_UPDATE_PREFIX*were booleans written only bycheckAllUpdates, and only installed plugins were looked up.Fix
hasAppUpdate,isPluginUpdateAvailableandgetInstalledPluginStatusescompare the cached latest tag with the current installed version at read timecheckAllUpdatescaches the latest tag of every plugin, not only installed onesNotes
Testing
./gradlew :app:compileStandardDebugKotlinpasses