Repository navigation
fix(screen): keep phones with a small display size on the compact profile - #850
Merged
Merged
Conversation
…file Since 4.3.2 any screen with 500dp or more in both dimensions counted as large, which defaults to the split keyboard. A regular phone with a small display size setting reaches that, so it got a split keyboard it never had before. The relaxed 500dp limit (added for unfolded foldables such as 588x706dp) now also requires a nearly square screen.
The screen profile line was written with android.util.Log, which the exported log does not contain, so reports could not be matched to a screen. Route it through the app logger and add the device model and screen size to the startup lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #843.
Problem
Since 4.3.2 the keyboard can show split on a regular phone that was never split before (4.3.1 was fine). Split defaults to on for the large screen profile, and a phone with a small display size setting can be 500dp or more wide and tall.
Cause
97c78f059(#778) lowered the large screen limit from 600x600dp to 500x500dp so unfolded foldables (e.g. 588x706dp, also without a hinge sensor) get the unfolded layout. That limit also matches phones with a small display size, which are tall and narrow.Fix
Logging
The exported log only holds warnings, errors and the app's own startup lines, so the screen profile line never showed up and reports could not be matched to a screen.
Testing
ScreenProfileTest: 13 tests pass./gradlew :app:compileStandardDebugKotlinpasses