Repository navigation
Refactor settings UI, harden receiver, add tests/CI, i18n and a11y fixes - #98
Merged
Merged
Conversation
added 14 commits
November 15, 2026 00:25
The docs/images/1-8.png files were byte-identical to the fastlane phoneScreenshots. Banners and badges in docs/images are kept.
scripts/check_strings.py compares every locale against values/strings.xml for missing/extra keys and format placeholder mismatches.
Lint currently reports 0 errors (271 warnings). abortOnError=true guards against new errors; checkReleaseBuilds stays false so release and F-Droid builds are unaffected.
Launches the settings screen under Robolectric (launch, first-launch redirect, recreate). Enables Android resources for unit tests and pins Robolectric to SDK 34 (max supported by 4.11.1). Guards onResume when onCreate returns early before prefs is initialized.
MainActivity.kt: 2404 -> 448 lines. Function bodies moved verbatim into Settings*.kt as MainActivity extension functions (binders, permissions, accordion, reorder, display/system/events sections, appearance, search) and ReorderAdapter.kt. Only visibility changed (private -> internal on shared members). Verified with smoke tests, lint and a minified release build.
…xplicit AwidgetProvider: the three goAsync() blocks now share runAsync(), which always releases the broadcast within 8s even if a data source hangs (finish() guarded to run once). SystemStatsFetcher: String.format now passes Locale.getDefault() explicitly (same behavior, resolves lint).
gradle/libs.versions.toml was not referenced by any build script (dependencies are declared in app/build.gradle.kts).
Not a standard Android permission and not referenced in code. The next alarm feature uses AlarmManager.getNextAlarmClock() and the ACTION_NEXT_ALARM_CLOCK_CHANGED broadcast, neither of which needs a permission.
… dialog 28 strings (weather dialogs, snackbars, widget picker, permission 'Granted' labels, notification text) were hardcoded in English; they now live in strings.xml with translations for all 11 locales. Permission labels reuse existing section_* strings. The duplicated 'Important Step' dialog is now a single showWeatherSetupHint(). Translations should be native-reviewed.
…rder list Decorative icons next to text labels are marked importantForAccessibility=no. Reorder rows gain TalkBack 'Move up/Move down' actions (previously touch-drag only), sharing the same persistence path as drag. Strings for 11 locales.
Centers the settings column (max 640dp) by widening the scroll view's side padding on wide screens; phones are unaffected. Pure inset function is unit tested, plus a wide-screen smoke test.
Dragging a slider ran updateWidget() (preview rebuild, FAB animation, widget broadcast) on every tick. Slider listeners now use scheduleWidgetUpdate(), a 120ms trailing debounce cancelled in onDestroy; discrete actions are unchanged. User-initiated switch toggles give a light CLOCK_TICK haptic.
LeanBitLab
force-pushed
the
chore/improvements
branch
from
November 14, 2026 20:28
06ca5a9 to
3af1579
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MainActivity.ktsplit from 2,404 to 448 lines; section code moved verbatim intoSettings*.ktextension files (onlyprivate->internalon shared members).AwidgetProviderbroadcast work now shares onerunAsync()helper that always releasesgoAsync()within 8s;String.formatcalls use an explicit locale.strings.xmlwith translations for all 11 locales (translations need native review). Duplicate "Important Step" dialog is now one function.MainActivity, plus tests forFallbackPreferences,ReorderAdapter(incl. accessibility actions), update-alarm scheduling, content-width inset and update debounce. Newci.yml(strings check, unit tests, lint, debug build) on push tomainand PRs; lint now fails on errors only (0 currently; release/F-Droid builds still skip lint).scripts/check_strings.pyverifies all locales match the base strings and placeholders.ALARM_LISTENERpermission (not a standard permission, unreferenced; next-alarm usesAlarmManager.nextAlarmClock, which needs none), unusedgradle/libs.versions.toml, and duplicatedocs/images/1-8.png(README now points at the fastlane screenshots). No permissions were added.Notes
main, so they appear after merge.Test plan
./gradlew --offline testpasses./gradlew lintDebugpasses (0 errors)./gradlew assembleRelease(R8 minified) builds