Repository navigation
feat(config-registry-controller): add state struct for validation in @metamask/wallet - #11671
Open
mikesposito wants to merge 3 commits into
Open
mikesposito wants to merge 3 commits into
mikesposito wants to merge 3 commits into
Conversation
Contributor
🛑 Files requiring codeowner reviewTo merge this PR, you'll need to get approvals from the following owner groups. @MetaMask/emerging-opportunities or @MetaMask/networks (4 files)
@MetaMask/core-platform (expand for more) |
@metamask/wallet
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding state schema for
config-registry-controllerto@metamask/walletNote
Low Risk
Additive schema and typing with unit tests; runtime controller behavior unchanged aside from stricter type alignment for persisted state shape.
Overview
Introduces a Superstruct-backed
ConfigRegistryControllerStateStructso@metamask/walletcan validate persisted controller state on startup, matching thestatic readonly structpattern used elsewhere (e.g.NetworkController).ConfigRegistryControllerStateis now inferred from that struct instead of a hand-written type, with network keys validated viaCaipChainIdStructandRegistryNetworkConfigSchema. Events config gets a sharedRegistryEventsConfigStructreused by both controller state and the events-config API response schema.Tests cover accepting valid persisted state and rejecting corrupt payloads. The changelog documents the addition.
Reviewed by Cursor Bugbot for commit 88189dd. Bugbot is set up for automated code reviews on this repo. Configure here.