Repository navigation
Conversation
厂商只认一个结尾:带着 last_frame_image 时,input_image 必须声明成 first_frame(或不声明)。原来按 kind 判断,首尾帧那一种被写成了 last_frame,于是厂商直接拒掉这条请求,画布上弹的是厂商的英文原文。 改成按 kind === 'lastFrame' 判断:只有末帧那一种声明 last_frame, 其余都声明 first_frame。README 里那张字段表跟着改。 单测全量 335 条通过(此前 334 条,新增一条顶层回归测试:首尾帧必须 声明首帧)。变异自检做过两处:把判断改回旧写法、把末帧换成首帧, 新测试都会变红。没有发真机生成请求。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
厂商只认一个结尾:带
last_frame_image的请求里,input_image必须声明成first_frame(或干脆不声明),否则厂商直接拒单。原来按
shape.kind判断:只有keyframe声明first_frame,其余(含firstLast)一律声明
last_frame。首尾帧这一种于是同时说了「结尾」和last_frame_image——两个结尾。画布上弹的是厂商原文:
改动
miniapp/node/connector-runner.mjs:shape.kind === 'lastFrame' ? 'last_frame' : 'first_frame'——只有末帧那一种声明last_frame,其余声明first_frame。README.md/README.zh-CN.md:字段表跟着改(首尾帧 =input_image+reference_type: first_frame+last_frame_image)。验收
影响
只影响 H3 / H3-Max 的首尾帧请求;首帧、末帧、参考集合三种请求的字段都没动。
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.