Skip to content

Fix v4.0.3 CI bugs by adding axis attributes to test datasets - #429

Merged
erikvansebille merged 2 commits into
mainfrom
fix_parcels_v4_0_3_break
Nov 20, 2026
Merged

erikvansebille merged 2 commits into
mainfrom
fix_parcels_v4_0_3_break

Conversation

@erikvansebille

Copy link
Copy Markdown
Member

This PR fixes the breaking CI that was caused by the new Parcels v4.0.3. Fortunately, there were no breaking changes in the core VirtualShip code itself - only in the creating of the dummy dataset in the unit tests

@ShaivanBhagat ShaivanBhagat left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. If i understand correctly, including the respective axis here for coordinates is to match the new parcels version?

@erikvansebille

Copy link
Copy Markdown
Member Author

If i understand correctly, including the respective axis here for coordinates is to match the new parcels version?

Yep, indeed. In the new Parcels version, we are more strict that all dimensions have to have an axis attribute (in the previous version we assumed that lon was always X etc - but it's cleaner to leave that to the user

@erikvansebille
erikvansebille merged commit 349bf8b into main Nov 20, 2026
12 checks passed
@erikvansebille
erikvansebille deleted the fix_parcels_v4_0_3_break branch November 20, 2026 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants