Repository navigation
Fix v4.0.3 CI bugs by adding axis attributes to test datasets - #429
Merged
Merged
Conversation
ShaivanBhagat
approved these changes
Nov 20, 2026
ShaivanBhagat
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me. If i understand correctly, including the respective axis here for coordinates is to match the new parcels version?
Member
Author
Yep, indeed. In the new Parcels version, we are more strict that all dimensions have to have an axis attribute (in the previous version we assumed that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the breaking CI that was caused by the new Parcels v4.0.3. Fortunately, there were no breaking changes in the core VirtualShip code itself - only in the creating of the dummy dataset in the unit tests