Repository navigation
chore: set $_ENV in the test sandbox and raise the coverage ratchet to 92 - #14
Merged
Merged
Conversation
added 5 commits
November 13, 2026 20:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two follow-ups to the coverage work merged in #12.
tests/Support/Sandbox.phpset the fake binaries'PATHinputenv()and$_SERVERonly. Symfony Process builds the environment of a child from$_SERVER, then lets$_ENVoverride it:$_ENVis empty with the php.ini of macOS (variables_orderGPCS) and filled on a PHP without php.ini (the officialphp:8.4-cliimage), where it brought back the originalPATHand made the fakecomposerunreachable (sh: composer: not found, 12 tests failing).$_ENVis now set too, and restored inrestore(). The CI does not have the problem, but the suite now passes in that Linux image as well..harness.jsongoes from 36.86 to 92: the CI measures 93.55 % onmainsince test: raise the coverage to 90.7 % #12 (the Line coverage line of the Quality gates job, recorded as improved). The merged test: raise the coverage to 90.7 % #12 had also reformatted the whole file; its original layout is restored, and only the number changes.117 tests pass on macOS and in a
php:8.4-clicontainer; Pint, PHPStan, Rector (--dry-run) andtests/Arch.phpare clean.