Repository navigation
Conversation
eitsupi
marked this pull request as ready for review
November 17, 2026 16:21
renkun-ken
approved these changes
Nov 17, 2026
renkun-ken
left a comment
Member
There was a problem hiding this comment.
Reviewed ce229c8. No actionable findings.
The tracing preserves the original promises and rejection behavior, reports pending stages when Mocha times out, and keeps successful tests quiet. The existing assertions and wait limits are preserved, and the expanded artifact glob captures renderer logs alongside extension-host logs.
Validation: compilation, TypeScript checks, focused lint and formatting checks passed. All nine HTML widget browser tests and the Workspace focus test passed locally on macOS with VS Code 1.145.2 and arf 0.7.2-rc.1. An isolated Mocha timeout smoke check confirmed that teardown emits exactly one report containing the pending stage and snapshot. All ten GitHub checks are passing.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two flaky failures could not be explained from their CI output. This adds diagnostics without changing assertions, expected values, or timeouts. Nothing extra is logged when a test passes.
waitForValue. The pages' own scripts ran, but link reports reached the browser instead of theopenExternalstub, and Find and fragment navigation reported no handling. This suggests that the viewer script injected by the extension did not run. Each wait is now named, and on failure the test reports the injected script tag and the file it should load,localResourceRoots, each viewer's revision and load state, and the lastwidget/loadedandlinkClickedmessages.