Skip to content

test: report diagnostics for HTML widget and Workspace focus timeouts - #1960

Open
eitsupi wants to merge 1 commit into
mainfrom
test/html-widget-and-workspace-focus-diagnostics
Open

eitsupi wants to merge 1 commit into
mainfrom
test/html-widget-and-workspace-focus-diagnostics

Conversation

@eitsupi

@eitsupi eitsupi commented Nov 17, 2026

Copy link
Copy Markdown
Member

Two flaky failures could not be explained from their CI output. This adds diagnostics without changing assertions, expected values, or timeouts. Nothing extra is logged when a test passes.

  • HTML widget browser rendering (Windows, nine tests): every test failed with "Timed out waiting for a session transition", the generic message of waitForValue. The pages' own scripts ran, but link reports reached the browser instead of the openExternal stub, and Find and fragment navigation reported no handling. This suggests that the viewer script injected by the extension did not run. Each wait is now named, and on failure the test reports the injected script tag and the file it should load, localResourceRoots, each viewer's revision and load state, and the last widget/loaded and linkClicked messages.
  • Interactive Workspace focus ("Workspace follows native focus and bound sources, and actions retain their displayed owner", macOS): the test sometimes ends at Mocha's 60 second timeout, which does not show which await was still running. Each step now records its duration, and on failure (including a Mocha timeout) the test reports every step's time, the step still pending, the active editor and notebook, the Workspace owner, and the state of its AgentClient.
  • CI now keeps all VS Code logs of the test profiles, including the renderer logs, rather than only the extension host logs.

@eitsupi
eitsupi marked this pull request as ready for review November 17, 2026 16:21

@renkun-ken renkun-ken left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed ce229c8. No actionable findings.

The tracing preserves the original promises and rejection behavior, reports pending stages when Mocha times out, and keeps successful tests quiet. The existing assertions and wait limits are preserved, and the expanded artifact glob captures renderer logs alongside extension-host logs.

Validation: compilation, TypeScript checks, focused lint and formatting checks passed. All nine HTML widget browser tests and the Workspace focus test passed locally on macOS with VS Code 1.145.2 and arf 0.7.2-rc.1. An isolated Mocha timeout smoke check confirmed that teardown emits exactly one report containing the pending stage and snapshot. All ten GitHub checks are passing.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants