Repository navigation
Conversation
alejoe91
approved these changes
Nov 17, 2026
Member
|
Thanks! |
Member
|
@evadiva3 can you flag the "Allow edits by maintainers"? The pre-commit reformatting service was not able to push the fixes. |
evadiva3
force-pushed
the
fix/probeinterface-1-missing-f-string-prefix
branch
from
November 17, 2026 17:33
701b111 to
5f3af12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing a boolean selection with the wrong length to
Probe.get_slice()prints literal{selection.shape}and{n}in the assertion message. Only the first of two adjacent strings is an f-string.Use one f-string so the message includes the supplied shape and contact count.
Validation:
pytest tests/test_probe.py— 21 passed. A direct call with a one-element selection on a two-contact probe reports(1,) != 2.