Repository navigation
ci(NOJIRA-123): name the build job after the node major so it matches the required check - #808
Merged
Merged
Conversation
…d check The "Require status checks" ruleset expects `build-lint-test - node 24`, but since #772 the job reported `build-lint-test - node 24.21.0`, leaving every PR waiting for a check that never arrives. Keep the exact version pinned in the matrix and use the major in the job name, so patch bumps no longer rename it. Co-Authored-By: Claude Opus 5.5 <[email protected]>
GitHub expressions can't strip a version down to its major, so keep the exact version in node_version for setup-node and add node_major for the job name. Co-Authored-By: Claude Opus 5.5 <[email protected]>
✅ Security Analysis ResultsNo security issues found. 1 files reviewed.
|
Collaborator
|
[BOT] Preview available with hash |
robespmun
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Every PR is stuck on
build-lint-test - node 24: Expected — Waiting for status to be reported.The "Require status checks" ruleset expects a check named
build-lint-test - node 24. Since #772 bumped the matrix to24.21.0, the job has been namedbuild-lint-test - node ${{ matrix.node_version }}, so it reports asbuild-lint-test - node 24.21.0. That name never matches, so the required check never arrives.What
node_majorkey next tonode_versionin thebuild-lint-testmatrix, and use it in the job name. GitHub expressions can't cut a version string down to its major, so the major is kept as its own value.setup-nodestill installs the exact24.21.0.A patch or minor bump now only touches
node_versionand doesn't rename the check. Moving to a new major (for example 26) changesnode_major, and the ruleset must be updated at the same time.After merging
The open Dependabot PRs (#793, #800, #801, #802, #804) have no workflow runs at all, because their last commits were pushed while Actions wasn't creating runs (2026-10-31 to 2026-11-09, and 2026-10-13). They need
@dependabot rebaseto get CI. Other open PRs pick up the new check name on their next push.🤖 Generated with Claude Code