Repository navigation
Disable pull-up when correlated inner columns are not a subset of the PARTITION BY columns - #2353
Open
andr-sokolov wants to merge 1 commit into
Open
andr-sokolov wants to merge 1 commit into
andr-sokolov wants to merge 1 commit into
Conversation
… PARTITION BY columns (apache#2274) Orca built invalid plan because it pulled up subquery which contains a window function during the Apply to Join transformations. Window function could return incorrect value after the pull-up because tuples number which this function was calculated over was changed after the optimization. The pull-up is safe when the correlated inner columns are a subset of the PARTITION BY columns. Otherwise the pull-up is disabled. FProcessProject processes CLogicalProject too. CLogicalProject processing is not changed. The queries to reproduce the bug are added to tests. Cherry-picked from b98a1e5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Orca built invalid plan because it pulled up subquery which contains a window
function during the Apply to Join transformations. Window function could return
incorrect value after the pull-up because tuples number which this function was
calculated over was changed after the optimization.
The pull-up is safe when the correlated inner columns are a subset of
the PARTITION BY columns. Otherwise the pull-up is disabled.
FProcessProject processes CLogicalProject too. CLogicalProject processing is
not changed.
The queries to reproduce the bug are added to tests.
Cherry-picked from b98a1e5