[jbampton]

https://github.com/pre-commit/pygrep-hooks

Official hooks from pre-commit some more basic checks or tests we can run

Description

This PR...

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[jbampton]

@blueorangutan package

[blueorangutan]

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 20.78%. Comparing base (c5bd11a) to head (04e4c86).

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #12933   +/-   ##
=========================================
  Coverage     20.77%   20.78%           
- Complexity    20855    20856    +1     
=========================================
  Files          6053     6053           
  Lines        548230   548230           
  Branches      73237    73237           
=========================================
+ Hits         113903   113923   +20     
+ Misses       420988   420959   -29     
- Partials      13339    13348    +9     

Flag	Coverage Δ
uitests	3.86% <ø> (ø)
unittests	22.21% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17311

[Copilot]

Pull request overview

Adds additional upstream pygrep-hooks checks to the repository’s pre-commit configuration to catch a few common Python/text pitfalls earlier in CI and local developer workflows.

Changes:

• Add python-check-mock-methods to detect common invalid unittest.mock method usages.
• Add python-use-type-annotations to discourage PEP 484 type comments in favor of annotations (with a targeted exclude).
• Add text-unicode-replacement-char to forbid UTF-8 replacement characters in committed files.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[DaanHoogland]

clgtm

[Copilot]

🟢 Approval recommended

The changes are limited to CI/pre-commit configuration, with only minor wording/spelling fixes suggested for clarity.

Review details

Suppressed comments (1)

.pre-commit-config.yaml:200

• The hook name uses the abbreviation "char" while the description spells out "character"; keeping these consistent avoids confusion.

        name: run check for no unicode replacement char

• Files reviewed: 1/1 changed files
• Comments generated: 1
• Review effort level: Lite

[borisstoyanov]

LGTM, @jbampton could you please check the comments above

[Copilot]

🟢 Approval recommended

No active review issues are present, and the changes are limited to adding pinned validation checks and clarifying documentation.

No open issues 🎉

1 resolved since last review

• The hook description uses "mck" (likely meant to be "mock") and the last example is missing…

_{Review effort: Lite}