Repository navigation
Remove leftover name-mapping bookkeeping from _ConvertToIceberg - #4381
Open
chenjian2664 wants to merge 1 commit into
Conversation
Name mapping moved out of this visitor into apply_name_mapping in apache#1014, but the docstring still claims it applies name-mapping IDs, and list() and map() still push and pop field names around the _field_id calls, which no longer read them.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the converter bookkeeping and docstring cleanup.
No open issues 🎉
What changed in this PR
Cleans up _ConvertToIceberg after name-mapping logic moved to apply_name_mapping in #1014, without changing field-ID selection or nested error-path tracking.
Changes:
- Removes redundant field-name stack updates around list and map ID lookups.
- Corrects the class docstring by removing the outdated name-mapping claim.
| File | Description |
|---|---|
pyiceberg/io/pyarrow.py |
Removes unused list/map bookkeeping and updates the converter docstring. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Name mapping moved out of
_ConvertToIcebergintoapply_name_mappingin #1014, but the class docstring still says it applies name-mapping IDs, andlist()andmap()still push and pop_field_namesaround_field_id, which no longer reads them. This removes that dead bookkeeping and corrects the docstring.Are these changes tested?
Are there any user-facing changes?