Skip to content

fix(ai-review): check.py's noqa for S603 passes ruff where S is off - #19

Merged
AlexeyShalaev merged 1 commit into
masterfrom
fix/noqa-s603
Nov 15, 2026
Merged

AlexeyShalaev merged 1 commit into
masterfrom
fix/noqa-s603

Conversation

@AlexeyShalaev

Copy link
Copy Markdown
Member

Takes check.py from bedrock-python/engineering-assets-template#19: # noqa: S603 becomes # noqa: S603, RUF100, so the file passes ruff in a repository that does not select S. The libraries select S, so nothing fails today; this keeps the hub's ai-review and workflow packs byte for byte the template's (checked file by file).

After the merge, distribute updates the 13 open sync PRs with this file.

@github-actions

Copy link
Copy Markdown

touchmark plan

Hub bedrock-python (github.com/1408350934) at a4948ce (PR #19) · touchmark v0.6.0 · strict

Provider Host Read Write Resolve
gh github.com bedrock-python-assets-read[bot] bedrock-python-assets-write[bot]: not checked resolve complete

Scope: pack ai-review changed → 13 of 13 targets (--all for every target)

opt_in: assumed: 11 targets without an opt-in file are opted in by targets.yml; an opt-in file with enabled: false opts one out

Outcome Targets
update 13
update (13)
  • gh:bedrock-python/aiokafka-foundation-kit #68 (content)
  • gh:bedrock-python/alembic-gauntlet #68 (content)
  • gh:bedrock-python/clientwright #77 (content)
  • gh:bedrock-python/deadline-budget #49 (content)
  • gh:bedrock-python/grpc-client-kit #62 (content)
  • gh:bedrock-python/grpc-server-kit #65 (content)
  • gh:bedrock-python/idempotency-kit #69 (content)
  • gh:bedrock-python/mattermind #63 (content)
  • gh:bedrock-python/omni-box #81 (content)
  • gh:bedrock-python/pg-partsmith #145 (content)
  • gh:bedrock-python/redis-client-kit #66 (content)
  • gh:bedrock-python/servicewright #120 (content)
  • gh:bedrock-python/sqlalchemy-foundation-kit #91 (content)
This hub pull request changes, across the targets it affects (26)
Change Path Targets
update ⚠ sensitive .claude/agents/reviewer.md 13
update ⚠ sensitive .claude/skills/commit/SKILL.md 13
update ⚠ sensitive .claude/skills/new-branch/SKILL.md 13
update ⚠ sensitive .claude/skills/pr/SKILL.md 13
update ⚠ sensitive .claude/skills/review-change/SKILL.md 13
update ⚠ sensitive .claude/skills/spec/SKILL.md 13
add ⚠ sensitive .agents/review/check.py 13
add ⚠ sensitive .agents/skills/commit/SKILL.md 13
add ⚠ sensitive .agents/skills/implement/SKILL.md 13
add ⚠ sensitive .agents/skills/new-branch/SKILL.md 13
add ⚠ sensitive .agents/skills/pr/SKILL.md 13
add ⚠ sensitive .agents/skills/review-change/SKILL.md 13
add ⚠ sensitive .agents/skills/spec/SKILL.md 13
add ⚠ sensitive .claude/skills/implement/SKILL.md 13
update AGENTS.md 13
update CLAUDE.md 13
add .agents/review/README.md 13
add .agents/review/directions/compatibility.md 13
add .agents/review/directions/correctness.md 13
add .agents/review/directions/design.md 13

and 6 paths more; the JSON report lists them all

Cost: gh ≈ 26 writes (<1 min) · 1 run

@AlexeyShalaev
AlexeyShalaev merged commit 0cd925e into master Nov 15, 2026
5 checks passed
@AlexeyShalaev
AlexeyShalaev deleted the fix/noqa-s603 branch November 15, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant