Repository navigation
fix(ai-review): check.py's noqa for S603 passes ruff where S is off - #19
Merged
Merged
Conversation
touchmark planHub
Scope: pack ai-review changed → 13 of 13 targets (--all for every target) opt_in: assumed: 11 targets without an opt-in file are opted in by targets.yml; an opt-in file with enabled: false opts one out
update (13)
This hub pull request changes, across the targets it affects (26)
and 6 paths more; the JSON report lists them all Cost: gh ≈ 26 writes (<1 min) · 1 run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes
check.pyfrom bedrock-python/engineering-assets-template#19:# noqa: S603becomes# noqa: S603, RUF100, so the file passes ruff in a repository that does not selectS. The libraries selectS, so nothing fails today; this keeps the hub'sai-reviewandworkflowpacks byte for byte the template's (checked file by file).After the merge, distribute updates the 13 open sync PRs with this file.