Repository navigation
Conversation
- Replace eslint, @eslint/js, globals and typescript-eslint with oxlint - Port eslint.config.js to .oxlintrc.json, keeping the same rules where oxlint has them - Drop the whitespace and formatting rules, which oxlint does not implement typescript-eslint was the only thing blocking TypeScript 7, and the four ESLint packages brought in all 11 open audit advisories. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces ESLint with oxlint.
typescript-eslintdoesn't support TypeScript 7 yet, and it is the only thing keeping #93 from passing. The four ESLint packages also brought in all 11 openbun auditadvisories (DoS and ReDoS issues inbrace-expansion,minimatchandpicomatch). oxlint is a standalone linter that doesn't use the TypeScript compiler, and it uses ESLint's rule names.Changes
eslint,@eslint/js,globalsandtypescript-eslintwithoxlint. The dependency tree goes from 104 packages to 25, andbun auditis clean.eslint.config.jsto.oxlintrc.json, with the same rules, severities and options wherever oxlint has them. Rules that ESLint's recommended and stylistic sets turned on, but that aren't in oxlint'scorrectnesscategory, are listed explicitly.check:linttakes about 20 ms instead of about 1 s.Rules that didn't carry over
semi,brace-style,keyword-spacing,arrow-spacing,block-spacing,semi-spacing,func-call-spacing,space-unary-ops,no-whitespace-before-property,no-trailing-spaces,no-floating-decimal,linebreak-style. oxlint doesn't implement formatting rules, and ESLint has deprecated them too..editorconfigand.gitattributesstill cover trailing whitespace, indentation and line endings.dot-notation,no-invalid-this,no-process-env,no-undef-init,require-atomic-updates. None of them flagged anything in this code.no-return-await,no-catch-shadow.@typescript-eslintversions ofno-unused-vars,no-unused-expressionsandno-array-constructorare now oxlint's rules of the same names, with the same options.no-native-reassignwas an old name forno-global-assign, which is still on.no-dupe-args,no-octalandno-octal-escapedescribe code that can't even parse as an ES module.TypeScript 7
On top of this branch, TypeScript 7.0.2 passes lint, build and tests. Once this lands, #93 should go green after a rebase.
One difference: under TS 7, the
dist/diff3.d.mtsthattscgenerates from the JS has looser inferred types (most return types becomeany[]).package.jsonexportspointtypesat the handwrittensrc/diff3.d.ts, which is unchanged, so normal imports aren't affected. It may be worth not generating that file at all, as a follow-up.🤖 Generated with Claude Code