Repository navigation
Pool LargeObject database connections via engine.raw_connection() - #1748
Merged
Merged
Conversation
Virv12
force-pushed
the
pool-large-object-connections
branch
from
November 17, 2026 17:53
e592856 to
fabd8cf
Compare
veluca93
approved these changes
Nov 17, 2026
Virv12
enabled auto-merge (rebase)
November 17, 2026 17:59
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1748 +/- ##
=======================================
Coverage 56.86% 56.86%
=======================================
Files 344 344
Lines 28364 28374 +10
=======================================
+ Hits 16128 16134 +6
- Misses 12236 12240 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Virv12
disabled auto-merge
November 17, 2026 18:06
Reuse SQLAlchemy's connection pool in LargeObject.__init__(), close(), and unlink() instead of opening a new unpooled psycopg2 connection via custom_psycopg2_connection() on every large object operation. Also fix the copy-paste error message in LargeObject.readinto(). Benchmarks on round1 DB (1,409 MB, 10,033 submissions, 11,182 blobs): - ExportSubmissions pattern (10,033 files): 68.62 s -> 4.53 s (15.1x) - Worker FileCacher cold cache (1,083 files, 1.44 GiB): 17.96 s -> 8.18 s (2.2x) - cmsDumpExporter -c 4 (11,182 files): 131.09 s -> 36.05 s (3.6x; files 122.16 s -> 26.70 s)
Virv12
enabled auto-merge (rebase)
November 17, 2026 18:20
Virv12
force-pushed
the
pool-large-object-connections
branch
from
November 17, 2026 18:20
fabd8cf to
7fc42a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuse SQLAlchemy's connection pool in LargeObject.init(), close(), and unlink() instead of opening a new unpooled psycopg2 connection via custom_psycopg2_connection() on every large object operation. Also fix the copy-paste error message in LargeObject.readinto().
Benchmarks on round1 DB (1,409 MB, 10,033 submissions, 11,182 blobs):