Repository navigation
Fix #15159 Wrong varid: function declaration with pointer-to-array parameter of unknown type - #8981
wjakobsson wants to merge 3 commits into
Conversation
|
Test results for commit 56694a0 (tools/test-my-pr.py, main compared to this PR): Test: http://ec2-16-170-140-253.eu-north-1.compute.amazonaws.com/pr-8981/ Posted automatically by the cppcheck PR test runner. +N: warnings only with this PR, -N: warnings only with main. The AI review is written by Claude and can be wrong. |
dmcppcheck
left a comment
There was a problem hiding this comment.
AI review
The PR introduces a varid regression. The condition now treats any name(...)[ in the first argument as a declaration. Because of that, global variables initialised with a subscripted function call, such as int x(g(1)[0]);, no longer get a varid. Base handled them correctly. The check should only accept the declarator shape (T (*p)[N] or T (&r)[N]), not every (...)[. The new test case passes and the existing varid tests still pass.
Testing
I built cppcheck and testrunner in pr/ and cppcheck in base/. ./testrunner TestVarID reports 0 failed tests out of 227.
Regression: scratch/a.cpp:
int* g(int);
int x(g(1)[0]);
int y(g(1)[0] + 1);
A h(T (*p)[16]);
A k(T (*p)[16], int n);
void f() { x = 1; y = 2; }Command: cppcheck --debug --verbose a.cpp
base:
2: int x@var1 ( g ( 1 ) [ 0 ] ) ;
3: int y@var2 ( g ( 1 ) [ 0 ] + 1 ) ;
4: A h@var3 ( T ( * p@var4 ) [ 16 ] ) ;
6: void f ( ) { x@var1 = 1 ; y@var2 = 2 ; }
pr:
2: int x ( g ( 1 ) [ 0 ] ) ;
3: int y ( g ( 1 ) [ 0 ] + 1 ) ;
4: A h ( T ( * p@var1 ) [ 16 ] ) ;
6: void f ( ) { x@exprUNIQUE = 1 ; y@exprUNIQUE = 2 ; }
The PR fixes h and k. However, the global variables x and y lose their varids, and their later uses become unrelated expressions. I did not find a warning that changes because of this; I only compared the varid dumps.
Automated review of 56694a0 by Claude. The pull request was built and tested locally.
|
Test results for commit 09b35e0 (tools/test-my-pr.py, main compared to this PR): Test: http://ec2-16-170-140-253.eu-north-1.compute.amazonaws.com/pr-8981/ Posted automatically by the cppcheck PR test runner. +N: warnings only with this PR, -N: warnings only with main. The AI review is written by Claude and can be wrong. |
dmcppcheck
left a comment
There was a problem hiding this comment.
AI review
The C3 regression (int x(g(1)[0]); losing its varid) is fixed and has a test now. The new pattern only covers a single *, & or && directly before the name. Other pointer-to-array declarators are still read as variable initialisations, so the function still gets a wrong varid: T (*const p)[16] and T (**p)[16] are examples. I found no crash and no new false positive. One known ambiguity is left: at global scope, int x(g(*q)[0]); with an undeclared q is now treated as a declaration, so x loses its varid. That case is ambiguous anyway and was mentioned in C3.
Comments
| # | Comment | By | Where | Status |
|---|---|---|---|---|
| 1 | int x(g(1)[0]); at global scope loses its varid |
AI review | general | ✅ Fixed |
| 2 | The (|[ check is too broad; only the declarator form should be excluded, and a test should be added |
AI review | lib/tokenize.cpp:5065 |
✅ Fixed |
| 3 | Only a single */& declarator is recognised; (*const p)[N] and (**p)[N] still get a wrong varid |
AI review | lib/tokenize.cpp:5062 |
🆕 New (false negative) |
@wjakobsson, please fix, resolve or reply to the open and new comments: #3.
For #3 (false negative), it is enough to create a Trac ticket and link it here. It does not need to be fixed in this PR.
Testing
I built cppcheck and testrunner in pr/ and cppcheck in base/. ./testrunner TestVarID ran 229 tests with 0 failures.
scratch/a.cpp:
A h1(T (&r)[16]);
A h2(T (&&r)[16]);
A h3(T (*const p)[16]);
A h4(T (**p)[16]);
A h5(T (*p)[16][4]);
A h6(T (*p)[16], int n);
int *gp;
int x1(g(*gp)[0]);
int x2(g(*q)[0]);
void f(){ x1=1; x2=2; }Command: cppcheck --debug --verbose a.cpp. Output of the PR:
1: A h1 ( T ( & r@var1 ) [ 16 ] ) ;
2: A h2 ( T ( && r ) [ 16 ] ) ;
3: A h3@var2 ( T ( * const p@var3 ) [ 16 ] ) ;
4: A h4@var4 ( T ( * * p@var5 ) [ 16 ] ) ;
5: A h5 ( T ( * p@var6 ) [ 16 ] [ 4 ] ) ;
6: A h6 ( T ( * p@var7 ) [ 16 ] , int n@var8 ) ;
...
8: int x1@var10 ( g ( * gp@var11 ) [ 0 ] ) ;
9: int x2 ( g ( * q@var12 ) [ 0 ] ) ;
10: void f ( ) { x1@var10 = 1 ; x2@exprUNIQUE = 2 ; }
Base gives every line a varid, h1 to h6 included. The PR fixes h1, h2, h5 and h6. h3 and h4 still give the function a varid (a false negative of the fix). x2 loses its varid, but that input is ambiguous. In x1, gp gets a fresh varid instead of reusing the existing one; base does the same, so this is not new.
I also checked a declaration inside a struct, inside a namespace and inside a function body (scratch/b.cpp). The struct and namespace cases are fixed. Inside the function body the output only shifts the varid numbers compared to base, and y keeps its varid.
Automated review of 84aa8d9 by Claude. The pull request was built and tested locally.
| (tok3->isName() && (variableMap.hasVariable(tok3->str()) || | ||
| (tok3->strAt(-1) == "(" && Token::simpleMatch(tok3->next(), "(") && !Token::simpleMatch(tok3->linkAt(1)->next(), "(")))) || | ||
| (tok3->strAt(-1) == "(" && Token::simpleMatch(tok3->next(), "(") && !Token::simpleMatch(tok3->linkAt(1)->next(), "(") && | ||
| !(Token::Match(tok3->next(), "( *|&|&& %name%| ) [") && !variableMap.hasVariable(tok3->strAt(3)))))) || |
There was a problem hiding this comment.
AI review
The pattern ( *|&|&& %name%| ) [ only matches a single pointer or reference token directly before the name. Other pointer-to-array declarators are still read as variable initialisations, so the function name still gets a varid:
A h3(T (*const p)[16]); // A h3@var2 ( T ( * const p@var3 ) [ 16 ] ) ;
A h4(T (**p)[16]); // A h4@var4 ( T ( * * p@var5 ) [ 16 ] ) ;One way to fix this is to skip a run of *|&|&&|const|volatile tokens before the name, for example by walking from tok3->tokAt(2) up to the ) and then checking for ) [.
No description provided.