Repository navigation
Fix #15208 (cppcheck-suppress-macro has no effect on a macro whose body is a single macro call) #9018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JayToltTech
wants to merge
4
commits into
cppcheck-opensource:main
Choose a base branch
from
JayToltTech:fix-15208-suppress-macro-nested
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+82
−3
Open
Fix #15208 (cppcheck-suppress-macro has no effect on a macro whose body is a single macro call) #9018
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
5a5c660
Fix #15208 (cppcheck-suppress-macro has no effect on a macro whose bo…
JayToltTech 06cdcba
Only count macro usages that produced tokens on the line
JayToltTech 82ffca5
Use std::transform to collect macro usage names
JayToltTech 6c9ac81
Match an unexpanded macro name by column, not by line
JayToltTech File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AI review
The macro usage list from simplecpp only has usages of macros that are still defined at the end of preprocessing.
simplecpp::preprocessbuilds it by iterating over the finalmacrosmap. If the outer macro is#undef'd (or redefined) after it is used, its usages are gone and the suppression still doesn't match:The PR still reports
zerodivon line 5 plusUnmatched suppression: zerodiv. Fixing this probably needs a change in simplecpp. Otherwise, a TODO test or a note would help.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed,
#undef ALIASafter the use still giveszerodivplus the unmatched suppression. That one is simplecpp, the usage list only has the macros still defined when preprocessing ends.Opened cppcheck-opensource/simplecpp#764 for it. It reports the usages when the definition goes away, so
#undefand redefinition both keep them. With that dropped intoexternals/simplecpplocally your example is suppressed.6c9ac81 has it as a TODO test here until simplecpp gets bumped.