Repository navigation
Fix #10253 arrayIndexOutOfBounds issue in inline function lacks context #9034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chrchr-github
wants to merge
11
commits into
cppcheck-opensource:main
Choose a base branch
from
chrchr-github:chr_10253
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+62
−42
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
233c533
Update checkimpl.cpp
chrchr-github 0b1fb56
Update testbufferoverrun.cpp
chrchr-github c03aeb1
Update checkimpl.cpp [skip ci]
chrchr-github 6d1c540
Update checkbufferoverrun.h [skip ci]
chrchr-github 4708686
Update checkbufferoverrun.cpp [skip ci]
chrchr-github 67659a6
Update testbufferoverrun.cpp
chrchr-github 4caa17c
Update token.h [skip ci]
chrchr-github 18a195d
Update token.cpp
chrchr-github 97b9e68
Update testbufferoverrun.cpp [skip ci]
chrchr-github f7ba0df
Update checkbufferoverrun.h [skip ci]
chrchr-github 54fd8e4
Update checkbufferoverrun.cpp
chrchr-github File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AI review
getErrorPath()addsvalue->errorPathonly withverbose, xml output or a non-emptytemplateLocation. In the other cases it keeps only the condition and the error token. The size'serrorPathis added here in every case. With a template that has no location part (--template='{callstack}: {id}: {message}'), the output is now[a.c:3] -> [a.c:6]: ... 'p[10]' accessed at index 10. The size path from line 3 is shown, but the index path (assignmenti=10and the condition at line 5) is still hidden. This is also why many existing testrunner expectations changed from one location to two. Consider adding the size path only under the same condition thatgetErrorPathuses, or putting the logic in one helper.negativeIndexErrordoes not get the size path either, so the two warnings for the same array are inconsistent.