Skip to content

Fix #762 (CI: use target commands instead of directory-level commands in CMakeLists.txt) - #763

Merged
danmar merged 1 commit into
masterfrom
fix-762
Nov 16, 2026
Merged

danmar merged 1 commit into
masterfrom
fix-762

Conversation

@danmar

@danmar danmar commented Nov 16, 2026

Copy link
Copy Markdown
Collaborator

Newer CMake reports add_definitions(), add_compile_definitions() and add_compile_options() as non-target directives, and -Werror=dev makes the configure step fail. Collect the compile options and definitions in lists and apply them with target_compile_options() and target_compile_definitions() to simplecpp_obj, simplecpp and testrunner. The compiler command lines are unchanged.

… in CMakeLists.txt)

Newer CMake reports add_definitions(), add_compile_definitions() and
add_compile_options() as non-target directives, and -Werror=dev makes
the configure step fail. Collect the compile options and definitions in
lists and apply them with target_compile_options() and
target_compile_definitions() to simplecpp_obj, simplecpp and testrunner.
The compiler command lines are unchanged.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@danmar
danmar merged commit 31989dd into master Nov 16, 2026
47 checks passed
@danmar
danmar deleted the fix-762 branch November 16, 2026 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants