Repository navigation
fix(auth): migrate local credentials to salted Argon2id (#1432) - #1466
Merged
Merged
Conversation
Contributor
Author
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local credentials are stored as unsalted MD5. Use independently salted Argon2id for new credentials, wrap historical MD5 values in a resumable migration, and upgrade verified eligible accounts to direct Argon2id on login without changing their passwords.
Cover initialization, creation/import, resets, password changes, initial-password policy, MCP and token compatibility. Conditional updates protect concurrent resets; API responses exclude credential hashes. Downgrade preserves strong credentials, so old application versions cannot read the new format.
Validation: 99 backend/guard tests passed on head 7f90287; 2 PostgreSQL-only cases skipped in that run. Before the baseline rebase, 38 isolated PostgreSQL cases and 4 password-component Playwright cases passed. The user confirmed historical-account login after applying the compatibility reader. Full host SDK browser handshake, container deployment and target-environment concurrency testing were not performed.
Fixes #1432