Repository navigation
Conversation
Bind libdiffpy's CPU kernels and batch atomic structure conversion through NumPy arrays. Preserve displacement tensors for shared atoms, honor custom atom and crystal accessors, and reuse ObjCryst data for native crystals. Validate site indices and cover converter registration and class lifetime.
Expose CUDA PDF and Debye kernels and their precision controls. Build CUDA-enabled wheels and cover CPU fallback on Windows hosts without a CUDA driver. Pin the embedded library to its upstream CUDA merge.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #107 +/- ##
==========================================
- Coverage 98.69% 97.90% -0.80%
==========================================
Files 26 29 +3
Lines 3834 4580 +746
==========================================
+ Hits 3784 4484 +700
- Misses 50 96 +46
🚀 New features to boost your workflow:
|
SYMSCAE
marked this pull request as ready for review
November 20, 2026 06:58
Contributor
Author
|
@sbillinge PR ready for review. Again, codecov is failing because it's not happy with cuda builds not being tested... |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates bindings for
libdiffpycommit994aaf2. See diffpy/libdiffpy#76 and diffpy/libdiffpy#78 for changes and benchmarks.Additional changes
diffpy.srreal.calculationkernelto list and select CPU and CUDA kernels for calculators.getAtomArrays()andsetAtomArrays()toAtomicStructureAdapterfor bulk access to atom data, and speed up conversion ofdiffpy.structureandpyobjcryststructures.cudaandcuda-mixedkernels in x86-64 wheels for Linux and Windows.