Repository navigation
Conversation
This was referenced Nov 17, 2026
rumpl
force-pushed
the
rumpl/markdown-transform-leantui
branch
from
November 17, 2026 22:47
7ada373 to
73b9197
Compare
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the lean TUI display-only transformer integration.
No open issues 🎉
What changed in this PR
Extends the existing display-only Markdown transformer pipeline to the lean TUI, while keeping stored replies, model context, and copied messages unchanged.
Changes:
- Connects transformers to the lean event loop with batched refreshes and message/session completion tracking.
- Renders transformer styling, preserves terminal scrollback, and shows the latest result or source text in the final frame.
- Adds focused tests and documents lean TUI support.
| File | Description |
|---|---|
pkg/leantui/update.go |
Reattaches transformers on session resume and marks restored replies complete. |
pkg/leantui/ui/transform_test.go |
Tests transformed rendering, completion, final-frame behavior, and scrollback preservation. |
pkg/leantui/ui/transcript.go |
Tracks per-block transform state, refreshes cached output, and settles final rendering. |
pkg/leantui/ui/render.go |
Adds rendering that preserves trusted transformer SGR styling. |
pkg/leantui/transform_test.go |
Tests compaction, nested-stream completion, and unchanged chunk boundaries. |
pkg/leantui/leantui.go |
Starts transformers, handles asynchronous refreshes, and prepares the final frame. |
pkg/leantui/events.go |
Tracks session streams and completes replies on saved-message or stream-stop events. |
docs/configuration/user-settings/index.md |
Documents lean TUI transformer support and scrollback behavior. |
Review effort: Balanced
Run settings.markdown_transformers in the lean TUI too. Transformed replies render with their SGR styling; rows already in terminal scrollback are never cleared, so changed text is written again below them, and styling-only changes are skipped. Replies complete when their saved message arrives or the last stream of their session stops, without flushing the pending block, so chunk boundaries do not depend on transformers. The final frame shows each reply's latest result, or its source when that snapshot has none yet. Signed-off-by: Djordje Lukic <[email protected]>
rumpl
force-pushed
the
rumpl/markdown-transform-leantui
branch
from
November 17, 2026 22:58
73b9197 to
ade921e
Compare
| m.ignoredUsers = nil | ||
| m.busy = false | ||
| m.streamDepth = 0 | ||
| m.sessionStreams.Reset() |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Runs
settings.markdown_transformers(#4952) in the lean TUI too.Last of a stack:
Validation
task build; race tests forpkg/markdowntransform,pkg/tui/...,pkg/leantui/...(lean transform tests 10× and 6× under load)golangci-lintreports no new issues; Windowsgo vetpassestask testfails only on the existingTestACPRuntimeConfig_ModelSwitchingIsSessionOwned