Repository navigation
Conversation
testower
marked this pull request as draft
October 16, 2026 12:33
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
teppope
force-pushed
the
feat/parking-availability-conditions
branch
from
November 5, 2026 09:27
8e7dd5a to
4bd62f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consumers can look up the opening hours of a parking by parking id, with
getAvailabilityConditionsByParkingIdIndex()onNetexEntitiesIndex.SiteFrameParserfills the index from theAvailabilityConditionelements invalidityConditionsof eachParking.NetexEntitiesIndexImplholds the backingMultimap<String, AvailabilityCondition>.org.entur.netex2.modelclasses (netex2-java-model 3.0.0).Before this change, the parser put
AvailabilityConditionelements into the rawParkingobject only. Consumers had no direct query path for parking opening hours.Verification
mvn verify -P prettierCheck— BUILD SUCCESS, 39 tests, 0 failuresTestParkingAvailabilityConditions— 4 tests greenSiteFrameParserof master, 3 of 4 tests fail (expected: <2> but was: <0>and twoNoSuchElementException: No value present). The test without conditions stays green.Known limitations
NetexEntitiesIndexmust addgetAvailabilityConditionsByParkingIdIndex(). The new method is abstract, as the other index getters are.