Repository navigation
test(sandbox): cover the default application base path - #344
Merged
Merged
Conversation
The coverage gate failed on release/v2.0.4 because every MigrateSandbox test overrode applicationBasePath(). Probe it through a namespaced base_path shim, as the file already does for Fleetbase\Support.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/v2.0.4 #344 +/- ##
==================================================
Coverage ? 100.00%
Complexity ? 9964
==================================================
Files ? 532
Lines ? 30374
Branches ? 0
==================================================
Hits ? 30374
Misses ? 0
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the red
buildcheck on #343.The coverage gate requires 100%. It failed with
MigrateSandbox.phpat 39/40, because every test from #342 overridesapplicationBasePath(), so its defaultreturn base_path();never ran.base_pathshim. This is the same pattern the file already uses forFleetbase\Support. No production code changes.vendor/bin/pest tests/Unit/Consolepasses (112). php-cs-fixer reports nothing to fix in the touched files.