Repository navigation
Conversation
Contributor
|
5 of 9 tasks
📲 Install BuildsAndroid
|
Avoid recording a provisional response status before the container handles an escaping exception. Preserve transaction finishing and error status, and verify omission across all three servlet integrations. Refs #6557 Co-Authored-By: Claude <[email protected]>
Add an unset option for ignored incoming server HTTP status codes and ranges. Parse external configuration without clearing existing values when all entries are invalid, and support Spring Boot binding across all supported versions. This PR only adds configuration surfaces; filtering remains unchanged. Refs #4735
Drop completed incoming server HTTP transactions when their root response status matches a configured range. Preserve lifecycle finalization while skipping processors, callbacks, envelope creation, and replay registration for filtered transactions. Record transaction, span, and profile losses, clean up temporary profile traces, and cover Spring Boot servlet and WebFlux integrations. Fixes #4735
Reference PR #6566 from the user-facing feature entry now that the stacked pull request has been created.
Stop sending incoming server transactions that finish with HTTP 404 unless users replace or clear the ignored status configuration. Document the opt-out and cover native Spring and OpenTelemetry paths across supported Spring Boot generations. Fixes #4736
Support unquoted numeric entries in Spring Boot YAML lists while preserving status code validation across Boot 2, 3, and 4. Refs #4735 Co-Authored-By: Claude <[email protected]>
# Conflicts: # sentry-spring-boot-4/src/test/kotlin/io/sentry/spring/boot4/SentryAutoConfigurationTest.kt # sentry-spring-boot-jakarta/src/test/kotlin/io/sentry/spring/boot/jakarta/SentryAutoConfigurationTest.kt # sentry-spring-boot/src/test/kotlin/io/sentry/spring/boot/SentryAutoConfigurationTest.kt
Default traceIgnoreStatusCodes to 301-303, 305-399, and 401-404 instead of only 404. Update documentation and boundary coverage so excluded gaps remain captured. Refs #4736 Co-Authored-By: Claude <[email protected]>
romtsn
approved these changes
Nov 17, 2026
romtsn
marked this pull request as ready for review
November 17, 2026 10:42
romtsn
marked this pull request as draft
November 17, 2026 10:43
romtsn
self-requested a review
November 17, 2026 10:43
Store traceIgnoreStatusCodes in a copy-on-write list so callers can mutate the exposed configuration while transactions iterate it. Mark the replaceable reference volatile so setter updates are visible across threads. Refs #4736 Co-Authored-By: Claude <[email protected]>
Expose the values supported by the sentry.kind convention and use the server constant across Spring and OpenTelemetry instrumentation. This keeps convention keys and values separate while avoiding duplicated literals. Refs #4735 Co-Authored-By: Claude <[email protected]>
Use the shared server span-kind value when identifying server transactions for HTTP status filtering. Refs #4735 Co-Authored-By: Claude <[email protected]>
# Conflicts: # sentry/src/test/java/io/sentry/SentryClientTest.kt
Extract the duplicated client-report accounting used when transactions are filtered by name or HTTP status. Refs #4735 Co-Authored-By: Claude <[email protected]>
Handle the supported integer status types through Number after validating the runtime type, preserving fail-open behavior for other numeric values. Refs #4735 Co-Authored-By: Claude <[email protected]>
…umentation (#6557) * feat(tracing): [Ignore HTTP Status 1] Add sentry.kind to server instrumentation Classify incoming Spring and OpenTelemetry server spans with sentry.kind and record numeric HTTP response statuses for later filtering. Refs #4735 Refs #4736 Refs #6555 * fix(spring): Omit unreliable HTTP status on escaping exceptions Avoid recording a provisional response status before the container handles an escaping exception. Preserve transaction finishing and error status, and verify omission across all three servlet integrations. Refs #6557 Co-Authored-By: Claude <[email protected]> * feat(core): Add Sentry span kind constants Expose the values supported by the sentry.kind convention and use the server constant across Spring and OpenTelemetry instrumentation. This keeps convention keys and values separate while avoiding duplicated literals. Refs #4735 Co-Authored-By: Claude <[email protected]> --------- Co-authored-by: Claude <[email protected]>
…ration (#6559) * feat(core): [Ignore HTTP Status 2] Add tracing status configuration Add an unset option for ignored incoming server HTTP status codes and ranges. Parse external configuration without clearing existing values when all entries are invalid, and support Spring Boot binding across all supported versions. This PR only adds configuration surfaces; filtering remains unchanged. Refs #4735 * fix(spring): Bind integer HTTP status codes from YAML Support unquoted numeric entries in Spring Boot YAML lists while preserving status code validation across Boot 2, 3, and 4. Refs #4735 Co-Authored-By: Claude <[email protected]> --------- Co-authored-by: Claude <[email protected]>
… statuses (#6566) * feat(tracing): Filter configured incoming HTTP statuses Drop completed incoming server HTTP transactions when their root response status matches a configured range. Preserve lifecycle finalization while skipping processors, callbacks, envelope creation, and replay registration for filtered transactions. Record transaction, span, and profile losses, clean up temporary profile traces, and cover Spring Boot servlet and WebFlux integrations. Fixes #4735 * chore: Link HTTP status filter changelog entry Reference PR #6566 from the user-facing feature entry now that the stacked pull request has been created. * Format code * ref(tracing): Use span kind constant for filtering Use the shared server span-kind value when identifying server transactions for HTTP status filtering. Refs #4735 Co-Authored-By: Claude <[email protected]> * ref(core): Share ignored transaction accounting Extract the duplicated client-report accounting used when transactions are filtered by name or HTTP status. Refs #4735 Co-Authored-By: Claude <[email protected]> * ref(core): Simplify HTTP status conversion Handle the supported integer status types through Number after validating the runtime type, preserving fail-open behavior for other numeric values. Refs #4735 Co-Authored-By: Claude <[email protected]> --------- Co-authored-by: Sentry Github Bot <[email protected]> Co-authored-by: Claude <[email protected]>
* feat(tracing): [Ignore HTTP Status 4] Ignore incoming 404s by default Stop sending incoming server transactions that finish with HTTP 404 unless users replace or clear the ignored status configuration. Document the opt-out and cover native Spring and OpenTelemetry paths across supported Spring Boot generations. Fixes #4736 * changelog * feat(tracing): Align ignored status defaults with spec Default traceIgnoreStatusCodes to 301-303, 305-399, and 401-404 instead of only 404. Update documentation and boundary coverage so excluded gaps remain captured. Refs #4736 Co-Authored-By: Claude <[email protected]> * fix(core): Make trace ignore statuses thread-safe Store traceIgnoreStatusCodes in a copy-on-write list so callers can mutate the exposed configuration while transactions iterate it. Mark the replaceable reference volatile so setter updates are visible across threads. Refs #4736 Co-Authored-By: Claude <[email protected]> --------- Co-authored-by: Claude <[email protected]>
runningcode
approved these changes
Nov 19, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Ignore HTTP Status)
📜 Description
Collection branch for the incoming server HTTP status filtering stack targeting
9.x.x.This branch intentionally contains only an empty collection commit. The implementation is split into four reviewable PRs covering server metadata, configuration, opt-in filtering, and the default 404 exclusion.
💡 Motivation and Context
The collection branch allows each stack PR to be merge-committed in order while the completed feature is eventually squash-merged into
9.x.xas one change.Refs #4735
Refs #4736
💚 How did you test it?
No runtime changes are included in this collection branch.
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Merge the four implementation PRs into this collection branch from bottom to top, then squash-merge this PR into
9.x.x.#skip-changelog