Repository navigation
fix: Stop swallowing errors in three places the Throwable audit found (JAVA-552) - #6670
Draft
runningcode wants to merge 4 commits into
Draft
runningcode wants to merge 4 commits into
runningcode wants to merge 4 commits into
Conversation
QueueFile deleted its file when reading it ran out of memory, as if the file were corrupt. It now resets the file only for the IndexOutOfBoundsException that a corrupt file causes. Installation wrapped an OutOfMemoryError in a RuntimeException. It now wraps only the IOException from reading or writing the installation file. The Ktor client integration swallowed coroutine cancellation while reading the response body for a failed-request event. It now rethrows CancellationException and fatal errors. Refs #5513 Refs JAVA-552 Co-Authored-By: Claude Opus 5.5 <[email protected]>
This was referenced Nov 18, 2026
Co-Authored-By: Claude Opus 5.5 <[email protected]>
5 of 9 tasks
📲 Install BuildsAndroid
|
Co-Authored-By: Claude Opus 5.5 <[email protected]>
…size Installation read the whole installation file into memory, so an oversized file could cause an OutOfMemoryError. It now reads at most 1 KB, enough for the UUID it holds, and treats a larger or unreadable file as corrupt and writes a new id. The Ktor client integration copied the whole response body to measure it for a failed-request event. It now takes the size from Content-Length, so it no longer reads the body at all, and can no longer swallow coroutine cancellation while doing so. Refs #5513 Refs JAVA-552 Co-Authored-By: Claude Opus 5.5 <[email protected]>
This was referenced Nov 19, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Fixes three bugs where a broad catch swallowed or mishandled an error:
QueueFileno longer deletes the offline cache when reading it runs out of memory. Only a corrupt file, which throwsIndexOutOfBoundsException, resets it.Installationno longer wraps anOutOfMemoryErrorin aRuntimeException. It reads at most 1 KB, and treats a larger or unreadable file as corrupt and writes a new id.Content-Lengthinstead of reading the body, so the size is missing when the response has noContent-Length.💡 Motivation and Context
This is part of the
catch (Throwable)audit. It's independent of the other JAVA-552 PRs, so it can merge in any order.💚 How did you test it?
No new tests, only the existing ones.
📝 Checklist
sendDefaultPIIis enabled.#skip-changelog
🤖 Generated with Claude Code