Repository navigation
Skip import reordering when comments separate imports. - #1528
Merged
Merged
Conversation
When a block or Javadoc comment separates `import` declarations, it is ambiguous which import the comment belongs to. Return an empty replacement list in `ImportOrderer.findReplacements` instead of throwing a `FormatterException` so the rest of the file can still be formatted. Fixes #424 PiperOrigin-RevId: 1023694754
copybara-service
Bot
force-pushed
the
test_1010281495
branch
from
November 17, 2026 14:44
5f49e7c to
46a200f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip import reordering when comments separate imports.
When a block or Javadoc comment separates
importdeclarations, it is ambiguous which import the comment belongs to. Return an empty replacement list inImportOrderer.findReplacementsinstead of throwing aFormatterExceptionso the rest of the file can still be formatted.Fixes #424