Skip to content

[AI] fix(schedules): show schedule names in the phone Link schedule dialog [sc-4216] - #357

Merged
kenlefeb merged 2 commits into
developmentfrom
sc-4216-link-schedule-names
Nov 14, 2026
Merged

kenlefeb merged 2 commits into
developmentfrom
sc-4216-link-schedule-names

Conversation

@kenlefeb

Copy link
Copy Markdown
Owner

Description

Related issue(s)

Testing

Checklist

  • Release notes added (see link above)
  • No obvious regressions in affected areas
  • Self-review has been performed - I have read every line of this diff and can explain what each change does and why it is needed

🤖 Generated with Claude Code

@kenlefeb

Copy link
Copy Markdown
Owner Author

🤖 Changes requested — Tester

Reviewed head b4d80aa. The row stacking in SchedulesTable.tsx looks correct and ScheduleLink is the only minimal caller, so the desktop table and other callers are unaffected. CI was still pending when I reviewed (check, docker-build, mobile-vrt, mobile-e2e, semgrep); the ones that had finished passed.

  1. ScheduleLink.tsx ~line 91-125: the header row (prompt text, Search width={300}, "Create New" button) is a non-wrapping flexDirection: 'row'. Modal.tsx caps the dialog at maxWidth: '90vw', which is about 337px on a 375px phone, so 300px search plus the button plus the prompt text overflows the dialog horizontally. Fix: when narrow, make this row wrap or stack, and let the search field take width="100%". Leave the 800px width as is, since maxWidth already caps it.
  2. The list flex-basis still uses ROW_HEIGHT (43). Use NARROW_ROW_HEIGHT for narrow screens so the stacked 76px rows get enough space.
  3. I could not complete the real-browser check. The demo budget would not finish loading in the dev build after my first mobile-viewport pass (stuck on "Initializing the connection to the local database"), and the phone web UI has no entry point for Link schedule. It only opens from the desktop table, so it needs the iPhone app or a window resized after the modal is open. No screenshot was captured. Please attach a phone-width screenshot of the dialog after fixing 1 and 2.

I will re-review once those are pushed.

@kenlefeb

Copy link
Copy Markdown
Owner Author

🤖 Approved — Tester

Reviewed head 0065f2e. My earlier findings are fixed in code:

  • On narrow screens the header stacks as a column and the search is 100% wide, so the 300px overflow is gone.
  • The Create New margin is removed on narrow screens.
  • The list flex-basis uses NARROW_ROW_HEIGHT.
  • ScheduleLink.test.tsx covers both the phone and the desktop layout.

Not verified: a real-browser phone-width check. The dev build hung on database init in my earlier attempt, so I did not retry. This approval rests on the code and the tests, and the phone check is left for staging after merge. CI was still pending when I looked.

@kenlefeb
kenlefeb enabled auto-merge November 13, 2026 23:55
@kenlefeb
kenlefeb merged commit 46ba056 into development Nov 14, 2026
13 checks passed
@kenlefeb
kenlefeb deleted the sc-4216-link-schedule-names branch November 14, 2026 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant