Repository navigation
Conversation
jackjusko
marked this pull request as ready for review
November 16, 2026 03:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3842. Related feedback: rejected PR #3860.
What changed
The progress window still raises and presents for new, reused, and status-icon-reopened operations. Before presentation, Nemo clears the default action and focuses the window's inert main container. The window remains focusable, and the Pause/Resume and Stop controls remain enabled and focusable. This prevents an Enter key carried over from the file view from activating Stop when the progress window appears.
Verification
meson compile -C buildcompleted successfully.meson test -C build --no-rebuild --print-errorlogscompleted with 2/5 tests passing: Content Search and Eel passed. The Copy test exits with its usage message (test-copy <sources...> <dest dir>) because the Meson test invocation supplies no arguments. Search Engine and Directory Async each timed out after 30 seconds. These suite issues were also seen in an earlier Nemo test run and are unrelated to this change.The existing icon-only action buttons have empty accessible names in AT-SPI. This patch leaves their presentation unchanged; they remain focusable and exposed. Naming those controls should be handled separately.
Manual regression procedure