Skip to content

Prevent Enter from stopping a newly presented copy dialog - #3891

Open
jackjusko wants to merge 1 commit into
linuxmint:masterfrom
jackjusko:fix-copy-dialog-enter-focus
Open

jackjusko wants to merge 1 commit into
linuxmint:masterfrom
jackjusko:fix-copy-dialog-enter-focus

Conversation

@jackjusko

Copy link
Copy Markdown

Fixes #3842. Related feedback: rejected PR #3860.

What changed

The progress window still raises and presents for new, reused, and status-icon-reopened operations. Before presentation, Nemo clears the default action and focuses the window's inert main container. The window remains focusable, and the Pause/Resume and Stop controls remain enabled and focusable. This prevents an Enter key carried over from the file view from activating Stop when the progress window appears.

Verification

  • meson compile -C build completed successfully.
  • meson test -C build --no-rebuild --print-errorlogs completed with 2/5 tests passing: Content Search and Eel passed. The Copy test exits with its usage message (test-copy <sources...> <dest dir>) because the Meson test invocation supplies no arguments. Search Engine and Directory Async each timed out after 30 seconds. These suite issues were also seen in an earlier Nemo test run and are unrelated to this change.
  • In a local X11 run, I started a real 20,000-file copy and sent Enter as the progress UI appeared; the operation continued and all 20,000 files completed.
  • With Orca and AT-SPI running, the progress window was exposed as an active frame, focus was on its inert filler, and both action controls were exposed as focusable buttons.

The existing icon-only action buttons have empty accessible names in AT-SPI. This patch leaves their presentation unchanged; they remain focusable and exposed. Naming those controls should be handled separately.

Manual regression procedure

  1. Focus Nemo's file view, start a file copy, and press Enter immediately as the progress window appears. Confirm the window is raised and the copy continues.
  2. Tab from the initial focus through Pause/Resume and Stop in both pending and running states. Confirm they remain accessible; Enter activates a button only when that button is intentionally focused.
  3. Repeat after the progress window has been hidden and reused, and after reopening it from the status icon. Confirm focus starts on the inert container each time.
  4. Confirm mouse controls still work and use Orca or AT-SPI to check that the progress information and controls remain exposed to assistive technology.

@jackjusko
jackjusko marked this pull request as ready for review November 16, 2026 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Copy dialog: Enter key accidentally cancels file copy

1 participant