Skip to content

split view: Fix reopening the extra pane at a missing location - #3893

Open
dualfroz wants to merge 1 commit into
linuxmint:masterfrom
dualfroz:fix/3742-extra-pane-missing-location
Open

dualfroz wants to merge 1 commit into
linuxmint:masterfrom
dualfroz:fix/3742-extra-pane-missing-location

Conversation

@dualfroz

Copy link
Copy Markdown
Contributor

when the folder the extra pane remembered is gone, F3 showed the error and closed the pane again. after the error the pane now opens the other pane's location, same as when nothing is remembered, the remembering itself stays as is. also nemo_window_split_view_on unreffed secondary_pane_last_location without taking a ref first, and it gets cleared (unreffed) again once the pane loads, so it now takes its own ref. Fixes #3742

- If the remembered location of the extra pane was deleted in the
  meantime, the load failed and the pane closed again right after the
  error. Fall back to the other pane's location instead.
- nemo_window_split_view_on() unreffed the remembered location without
  owning a ref, and the window unrefs it again when the new pane loads.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extra Pane fails to reopen and shows error if previously opened folder no longer exists

1 participant