Repository navigation
Conversation
- If the remembered location of the extra pane was deleted in the meantime, the load failed and the pane closed again right after the error. Fall back to the other pane's location instead. - nemo_window_split_view_on() unreffed the remembered location without owning a ref, and the window unrefs it again when the new pane loads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when the folder the extra pane remembered is gone, F3 showed the error and closed the pane again. after the error the pane now opens the other pane's location, same as when nothing is remembered, the remembering itself stays as is. also
nemo_window_split_view_onunreffedsecondary_pane_last_locationwithout taking a ref first, and it gets cleared (unreffed) again once the pane loads, so it now takes its own ref. Fixes #3742